Add DI spec tests for scope factory singleton, hierarchical scopes #68517
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add DI specification tests to ensure that conforming container implementations: - Implement IServiceScopeFactory as a singleton. - Provide service scopes that all branch from the container and are not hierarchical. Fix dotnet#67391
ghost
added
area-Extensions-DependencyInjection
community-contribution
|
Tagging subscribers to this area: @dotnet/area-extensions-dependencyinjection Issue DetailsFix #67391 Adds Microsoft.Extensions.DependencyInjection.Specification.Tests for ensuring:
Autofac, Grace, and DryIoc all fail one or both of these tests. Changes include adding explicit skip for the failing tests on those external containers. Also switched the
|
This was referenced Apr 25, 2022
Tests fail during CI build but succeed locally. Reverting change to troubleshoot later.
eerhardt
approved these changes
Apr 26, 2022
davidfowl
approved these changes
Apr 26, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #67391
Adds Microsoft.Extensions.DependencyInjection.Specification.Tests for ensuring:
IServiceScopeFactoryis a singleton.Autofac, Grace, and DryIoc all fail one or both of these tests. Changes include adding explicit skip for the failing tests on those external containers.
Also switched the
IServiceProviderIsServicetests on for Autofac since that is supported. All of those tests pass.