[release/10.0] Detect if RSA-384 is supported on the platform #120381
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR backports a fix to detect RSA-384 support dynamically on platforms rather than relying on hardcoded Windows version checks. The change responds to a Windows Update that caused RSA with 384-bit modulus operations to fail, breaking existing tests.
Key changes:
- Replaces static Windows version-based RSA-384 support detection with dynamic runtime testing
- Centralizes RSA-384 support detection in a shared
PlatformSupportclass - Updates all RSA provider test classes to use the new centralized detection method
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/libraries/Common/tests/System/Security/Cryptography/PlatformSupport.cs |
Adds new IsRSA384Supported property with dynamic detection logic and test RSA-384 key parameters |
src/libraries/System.Security.Cryptography/tests/DefaultRSAProvider.cs |
Replaces hardcoded Windows version check with centralized platform support detection |
src/libraries/System.Security.Cryptography.Csp/tests/RSACryptoServiceProviderProvider.cs |
Updates from hardcoded true to use centralized platform support detection |
src/libraries/System.Security.Cryptography.Cng/tests/RSACngProvider.cs |
Replaces hardcoded Windows version check with centralized platform support detection |
Contributor
|
Tagging subscribers to this area: @dotnet/area-system-security, @bartonjs, @vcsjones |
bartonjs
approved these changes
Oct 3, 2025
Member
|
@artl93 Test-only change |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #120366 to release/10.0
/cc @bartonjs
Customer Impact
This is test-only reaction to a change in Windows. Tests started failing in Windows because a Windows Update caused RSA with a 384-bit modulus to fail.
Regression
Testing
This is test only change. Verified failing tests started passing again.
Risk
None. Test-only change.