[release/10.0] Revert "Use a ReaderWriterLockSlim in RcwCache" #120372
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=80&v=4){kind=small}
This reverts commit a074813.
AaronRobinsonMSFT
added
Servicing-consider
|
Tagging subscribers to this area: @dotnet/interop-contrib |
jkoritzinsky
approved these changes
Oct 3, 2025
This was referenced Oct 3, 2025
AaronRobinsonMSFT
added
Servicing-consider
agocke
added
Servicing-approved
|
/ba-g Build analysis identifies all failures as known. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #120370 to release/10.0
/cc @AaronRobinsonMSFT
Customer Impact
This results in a random crash for scenarios involving
ComWrappers. Reported by partner teams in #119986and #120347.
Regression
This was regressed in #117792, which was an attempt to address a performance regression reported in #120347. At this point it has also become apparent that this approach didn't address the performance regression and instead uses the stronger guarantee of a simple lock.
Testing
This is resetting the functionality back to the known good implementation of using a simple lock.
Risk
Low from a functionality perspective, but Med from a risk perspective. However, the Med risk is narrowly impacting
ComWrapperscenarios (for example, WinRT).