-
Notifications
You must be signed in to change notification settings - Fork 5.2k
[browser] build browserhost in host.native subset #120298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Tagging subscribers to 'arch-wasm': @lewing, @pavelsavara |
32ecbfa
to
04232e2
Compare
Co-authored-by: SingleAccretion <[email protected]>
- add host.native - fix corehost/build.cmd
- add NATIVE_JAVASCRIPT_BIN and move all JS outputs there - split System.Native.Browser-Rollup and System.Native.Browser-NpmInstall into it's own native\libs\Common\JavaScript\CMakeLists.txt - make Rollup incremental
… later on customer machine - make browserhost dependent on .a files of `libs.native+clr.runtime` subsets, instaed of CMake target and sub_direcotry
That's already done, I also prefer that.
@jkoritzinsky could you please share more details ? It seems unless I change my direction, I may suffer same pains. For context:
|
# Conflicts: # src/mono/llvm/llvm-init.proj
For Linux and Windows, we were hitting issues with linker incompatibilities and a ton of complexity because of the flags we pass around and the fact that we shuffle pieces between different machines in the PR builds. For wasm, we already have an established path of shipping static libs, so I'm not as concerned that we'll hit the same problem. If you're able to pre-link everything with the new host like how we do the singlefilehost, I'd recommend that. If you can't, then splitting it is fine. |
On top of #120359
eng/native.props
host.native
subset back for coreCLR browsercorehost/build.cmd
CLR_ARTIFACTS_BIN_DIR
NATIVE_JAVASCRIPT_BIN
and move all JS outputs thereSystem.Native.Browser-Rollup
andSystem.Native.Browser-NpmInstall
into it's ownCommon\JavaScript\CMakeLists.txt
browserhost
forclr.runtime
subsetbrowserhost
intolibBrowserHost.a
, so that it could be linked later on customer machinebrowserhost
dependent on relevant.a
files oflibs.native+clr.runtime
subsets, instead of CMake target andadd_subdirectory
Fixes #120188