Update MemoryStream max capacity improvements #120091
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m.cs Co-authored-by: Copilot <[email protected]>
…ontu2912/runtime into fix_update_mode_max_size
Co-authored-by: Theodore Tsirpanis <[email protected]>
…ontu2912/runtime into fix_update_mode_max_size
github-actions
bot
added
the
needs-area-label
There was a problem hiding this comment.
Pull Request Overview
This PR follows up on the previous changes to update MemoryStream's maximum capacity improvements by addressing post-merge comments. The primary purpose is to replace hardcoded int.MaxValue references with Array.MaxLength for better consistency and accuracy in memory stream capacity handling.
- Replaced hardcoded
int.MaxValuereferences withArray.MaxLengththroughout MemoryStream implementation - Updated error messages to dynamically reference the actual maximum array length
- Added comprehensive test coverage for capacity boundary checks
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/libraries/System.Private.CoreLib/src/System/IO/MemoryStream.cs | Updated max length constant to use Array.MaxLength, added capacity validation, and improved error messages |
| src/libraries/System.Private.CoreLib/src/Resources/Strings.resx | Updated error message template to accept dynamic maximum length parameter |
| src/libraries/System.Runtime/tests/System.IO.Tests/MemoryStream/MemoryStreamTests.cs | Updated seek overflow tests and added new capacity boundary test |
| src/libraries/System.Runtime/tests/System.IO.Tests/BinaryWriter/BinaryWriterTests.cs | Updated test array to use Array.MaxLength instead of int.MaxValue |
jozkee
reviewed
Sep 25, 2025
…ontu2912/runtime into fix_update_mode_max_size
|
Current failures don't seem related to these changes |
|
/azp run runtime-libraries-coreclr outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jozkee
approved these changes
Sep 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up PR adressing post-merge comments for #119089