-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Adding GetProfilerModifiedILInformation and GetMethodsWithProfilerModifiedIL cDAC APIs #119975
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
GetMethodsWithProfilerModifiedIL cDAC APIs
Tagging subscribers to this area: @steveisok, @dotnet/dotnet-diag |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR implements two new cDAC (Contract-based Data Access Component) APIs for retrieving profiler-modified IL information: GetProfilerModifiedILInformation
and GetMethodsWithProfilerModifiedIL
. These APIs replace previous placeholder implementations with full contract-based implementations.
Key changes:
- Implementation of
GetProfilerModifiedILInformation
to detect and return information about methods with modified IL (either through ReJIT or profiler modification) - Implementation of
GetMethodsWithProfilerModifiedIL
to enumerate all methods in a module that have profiler-modified IL - Addition of supporting contract methods
GetDynamicIL
andHasDefaultIL
to enable the detection logic
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
File | Description |
---|---|
SOSDacImpl.cs | Implements the two main API methods with full logic for detecting profiler-modified IL |
ISOSDacInterface.cs | Adds DacpProfilerILData struct definition and updates method signature |
Loader_1.cs | Refactors GetILHeader method and exposes GetDynamicIL as public interface method |
CodeVersions_1.cs | Implements HasDefaultIL method to check if IL code version uses default IL |
ILoader.cs | Adds GetDynamicIL method to the ILoader contract interface |
ICodeVersions.cs | Adds HasDefaultIL method to the ICodeVersions contract interface |
Loader.md | Updates documentation to reflect the refactored GetILHeader and new GetDynamicIL method |
CodeVersions.md | Documents the new HasDefaultIL method |
src/native/managed/cdac/mscordaccore_universal/Legacy/SOSDacImpl.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me minus the small comments
No description provided.