Fix inverted gc contract condition for functions that may create a thread

[kg]

Thanks to @jkotas for noticing this

[Copilot]

Pull Request Overview

This PR fixes inverted garbage collector (GC) contract conditions in functions that may create threads in the CoreCLR runtime. The conditions were incorrectly specifying GC triggers for when a thread exists and disabled GC for when no thread exists, when it should be the opposite.

• Corrects the logic in CONTRACTL blocks across multiple CoreCLR VM files
• Ensures proper GC contract specifications for thread creation and management functions
• Affects functions in thread management, application domain operations, and host interface components

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File	Description
src/coreclr/vm/threadsuspend.cpp	Fixed GC contracts in UserAbort and ResumeAllThreads functions
src/coreclr/vm/threads.cpp	Corrected GC contracts in multiple thread lifecycle functions including constructors, setup, and cleanup
src/coreclr/vm/corhost.cpp	Updated GC contracts in host interface methods for app domain and delegate operations
src/coreclr/vm/appdomain.cpp	Fixed GC contracts in AppDomain friendly name operations

[dotnet-policy-service]

Tagging subscribers to this area: @mangod9
See info in area-owners.md if you want to be subscribed.

[kg]

I'll follow up on your comments and examine each method carefully, thanks

[kg]

Should CorHost2::ExecuteInAppDomain be GC_TRIGGERS since it invokes arbitrary code that might trigger GC? Isn't NOTHROW wrong for it too?

[jkotas]

Should CorHost2::ExecuteInAppDomain be GC_TRIGGERS since it invokes arbitrary code that might trigger GC?

Yes, that sounds right.

Isn't NOTHROW wrong for it too?

It catches all exceptions and converts them to HRESULT so it is NOTHROW. (NOTHROW means that no exception escapes. It does not prevent the implementation from throwing and caching.)

[kg]

Did a pass over everything and tried to update most of them so they aren't conditional. LMK if I got anything wrong.

[kg]

Following up on the non-contractL comments (I missed them originally)

[kg]

Think I got everything now. Sorry for the churn.

[jkotas]

Thanks!