[release/10.0] Add a flag to hostfxr_resolve_sdk2_flags_t to silence error messages #119736
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #119729 to release/10.0
See dotnet/sdk#50632 for context.
hostfxr_resolve_sdk2
will print error messages to stderr by default. We can add a flag to the enum to allow for silencing these errors when we want to try to resolve an sdk, but a failure to resolve shouldn't be surfaced to the console.Alternatives:
Customer Impact
[Select one or both of the boxes. Describe how this issue impacts customers, citing the expected and actual behaviors and scope of the issue. If customer-reported, provide the issue number.]
Regression
Testing
Unit tests were added to validate setting the flag does not iteract with other flags and that it does silence the stderr output.
Risk
Low. This adds a new flag to an existing API and should have no observable behavior on existing code. The main risk is that we come to regret the new public flag on the host API and have trouble deprecating it.