Skip to content

Conversation

vcsjones
Copy link
Member

Backport #118652
Backport #118777

Customer Impact

None, test only change.

Regression

  • Yes
  • No

Testing

These tests were failing against macOS 26 RC. They now pass against macOS 26 RC.

Risk

None, test only change.

@vcsjones vcsjones added this to the 8.0.x milestone Sep 15, 2025
@vcsjones vcsjones self-assigned this Sep 15, 2025
@Copilot Copilot AI review requested due to automatic review settings September 15, 2025 14:47
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR backports test fixes for macOS 26 Tahoe to the release/8.0-staging branch. The changes address test failures that were occurring specifically on macOS 26 RC by updating platform detection logic and adjusting test expectations to accommodate behavioral changes in the newer macOS version.

Key changes:

  • Adds detection for Apple platforms version 26 or later
  • Updates X509 certificate chain test logic to handle macOS 26 behavior differences
  • Adjusts test assertions for certificate chain validation on the new platform

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/libraries/Common/tests/TestUtilities/System/PlatformDetection.Unix.cs Adds IsApplePlatform26OrLater property for detecting macOS 26+
src/libraries/System.Security.Cryptography/tests/X509Certificates/ChainTests.cs Updates certificate chain tests to handle macOS 26 behavioral changes

@bartonjs bartonjs added the Servicing-consider Issue for next servicing release review label Sep 15, 2025
@bartonjs bartonjs enabled auto-merge (squash) September 15, 2025 20:19
@bartonjs bartonjs added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Sep 15, 2025
@bartonjs
Copy link
Member

Test-only change, applying servicing-approved under tell-mode.

This was referenced Oct 15, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Oct 16, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-System.Security Servicing-approved Approved for servicing release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants