Skip to content

Conversation

huoyaoyuan
Copy link
Member

Remove unused and unify multiple definitions to minipal/utils.h.

@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Sep 6, 2025
@huoyaoyuan
Copy link
Member Author

The failure is because mono redefines assert and doesn't use #undef to handle conflict:

#ifdef DEBUG
#if ABORT_ON_ASSERT_FAILURE
#define assert(x) if(!(x)) ABORT
#else /* ABORT_ON_ASSERT_FAILURE */
#include <assert.h>
#endif /* ABORT_ON_ASSERT_FAILURE */
#else /* DEBUG */
#define assert(x)
#endif /* DEBUG */

@jkotas
Copy link
Member

jkotas commented Sep 30, 2025

/azp run runtime-coreclr outerloop

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jkotas
Copy link
Member

jkotas commented Sep 30, 2025

/azp run runtime-libraries-coreclr outerloop

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@jkotas
Copy link
Member

jkotas commented Oct 1, 2025

/ba-g missing logs, insufficient info in logs (wasm/chrome crash)

@jkotas jkotas merged commit 73893d9 into dotnet:main Oct 1, 2025
240 of 254 checks passed
@huoyaoyuan huoyaoyuan deleted the pal/macros branch October 1, 2025 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-VM-coreclr community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants