[release/10.0] Fix ProfileEnter when called on a foreign thread #119349
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When ProfileEnter is called on a foreign thread that the runtime has not seen yet, which can happen for UnmanagedCallersOnly marked methods, it crashes in the GCX_COOP_THREAD_EXISTS(GET_THREAD()); That was left in by accident in my change I've made a long time ago and should not be there. This change removes that switch, we switch to cooperative mode later in the ProfileEnter and setup the thread for runtime before that. Close #115617
Contributor
|
Tagging subscribers to this area: @mangod9 |
jeffschwMSFT
approved these changes
Sep 4, 2025
Member
jeffschwMSFT
left a comment
jeffschwMSFT
left a comment
There was a problem hiding this comment.
approved. please get a code review. we can merge when ready
jkotas
approved these changes
Sep 4, 2025
Member
|
@janvorli can you take a look at the ci failures? |
Member
|
@jeffschwMSFT the test was killed due to the fact that it uses too much memory (@simonrozsival helped me to decipher that). I'll try to re-run the test, but it is not related to my change in any way. |
Member
|
@agocke can you please merge it in? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #119327 to release/10.0
/cc @janvorli
Customer Impact
When customers run a .NET application under a profiler and the application code has methods marked by the
[UnmanagedCallersOnly]attribute that are called from foreign threads, the runtime crashes during the profiling.Regression - introduced in the .NET
Testing
CI testing
Risk
Low, it removes a call that has no effect when the profiled method is not marked as
[UnmanagedCallersOnly]and crashes in the problematic call. The switch to GC cooperative mode that was done by that calls occurs later in theProfileEnter.