[wasm] native build flags #119307
Merged
[wasm] native build flags #119307
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavelsavara
added
arch-wasm
Contributor
|
Tagging subscribers to 'arch-wasm': @lewing |
Member
Author
|
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
pavelsavara
force-pushed
the
browser_mt_soft_fail
branch
from
e00a5c4 to
344ef49
Compare
Member
Author
|
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced Sep 3, 2025
Open
3 tasks
Member
Author
|
/azp run runtime-wasm |
pavelsavara
requested review from
akoeplinger,
ilonatommy,
lewing and
maraf
as code owners
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR changes the default behavior for native build flags in WebAssembly (WASM) builds, making them more conservative by default while allowing debug builds with native builds enabled to use debug symbols.
Key changes:
- Changes
WasmNativeDebugSymbolsdefault fromtruetofalse - Adds conditional logic so that Debug configuration with
WasmBuildNative=trueenables debug symbols and disables stripping - Removes the
-gflag for WASI builds whenWasmNativeStripis disabled, adopting changes from PR #115624
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/mono/wasm/data/aot-tests/ProxyProjectForAOTOnHelix.proj | Removes explicit debug symbols and strip configuration to use new defaults |
| src/mono/wasm/build/WasmApp.Common.targets | Updates property group conditions to set debug symbols based on configuration and strip settings |
| src/mono/wasm/Wasm.Build.Tests/WasmNativeDefaultsTests.cs | Updates test expectations to match new default behavior for debug symbols |
| src/mono/wasm/Wasm.Build.Tests/NativeRebuildTests/FlagsChangeRebuildTest.cs | Fixes rebuild logic to account for CFLAGS changes triggering recompilation |
| src/mono/wasi/wasi.proj | Removes override setting WasmNativeStrip to false for CI builds |
| src/mono/wasi/build/WasiApp.targets | Removes default WasmNativeDebugSymbols setting and conditional -g flag |
| eng/testing/tests.wasm.targets | Consolidates WASM test configuration, moving AOT-specific settings here |
| eng/testing/tests.wasi.targets | Removes WASI-specific debugger support configuration |
| eng/testing/tests.browser.targets | Removes browser-specific AOT configuration, moved to common targets |
| eng/pipelines/extra-platforms/runtime-extra-platforms-wasm.yml | Adds shouldContinueOnError flag for threading builds |
maraf
approved these changes
Sep 9, 2025
This was referenced Oct 5, 2025
Open
Open
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WasmNativeDebugSymbolsdefault tofalseDebugand ``WasmBuildNative ->WasmNativeStripdefaults to `false` and `WasmNativeDebugSymbols` default to `true`-gforWasmNativeStrip