-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Normalize whitespace in .resx
files
#119302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
7513dc0
to
c40a761
Compare
.resx
files.resx
files
The Visual Studio RESX editor adds these whitespaces so this removes friction somewhere and adds it elsewhere. Could we instead add a line that disables these editorconfig rules for RESX? |
I think the Visual Studio RESX editor adds the whitespace to new files, not to existing files. We already have many existing files that have the trailing whitespace removed. |
No, it will add it if it's missing. |
What is the editor's behaviour with respect to final newline? |
It removes the final newline |
I see, so this PR does indeed add friction. Could you confirm whether this behaviour is in the new Visual Studio Resource Explorer, or the old Resource Editor? |
* Update `.editorconfig` to adjust settings for `.resx` files to match VS Context: #119302 (comment), dotnet/android#4954. * Convert `.resx` files to `utf8` encoding (remove BOM) The following script was used: ```sh for file in $(find . -name '*.resx' -type f); do gsed -i '1s/^\xEF\xBB\xBF//' $file done ```
This PR normalizes whitespace in
.resx
files across the repository.Changes
[ \t]+$
).Motivation
The repository's
.editorconfig
specifies:Many editors enforce these settings automatically. Without normalizing the existing
.resx
files, unrelated whitespace changes can show up in otherwise unrelated PRs.By cleaning this up now, we reduce noise and friction in future contributions.
Notes