Fix misleading order of EventSource log and AcquireClientCredentials call #119262
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…call Discovered while investigating #119259. `AcquireClientCredentials` produces other events as well, so the order in the log is misleading and makes investigations harder.
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a misleading log order issue in the SslStream protocol handling. The AcquireClientCredentials call was happening before the EventSource logging, which made debugging more difficult since AcquireClientCredentials produces its own events that would appear before the "CredentialsNeeded" log message.
Key changes:
- Reorder EventSource logging to occur before
AcquireClientCredentialscall - Move the
refreshCredentialNeededflag assignment to maintain logical flow
|
Tagging subscribers to this area: @dotnet/ncl, @bartonjs, @vcsjones |
liveans
approved these changes
Sep 2, 2025
MihaZupan
approved these changes
Sep 2, 2025
wfurt
approved these changes
Sep 2, 2025
rzikm
commented
Sep 3, 2025
src/libraries/System.Net.Security/src/System/Net/Security/SslStream.Protocol.cs
Outdated
Show resolved
Hide resolved
…tream.Protocol.cs
|
/ba-g test failures are unrelated |
filipnavara
pushed a commit
to filipnavara/runtime
that referenced
this pull request
Sep 5, 2025
…call (dotnet#119262) * Fix misleading order of EventSource log and AcquireClientCredentials call Discovered while investigating dotnet#119259. `AcquireClientCredentials` produces other events as well, so the order in the log is misleading and makes investigations harder. * Update src/libraries/System.Net.Security/src/System/Net/Security/SslStream.Protocol.cs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discovered while investigating #119259.
AcquireClientCredentialsproduces other events as well, so the order in the log is misleading and makes investigations harder.