Skip to content

Conversation

tannergooding
Copy link
Member

This resolves #119008

@Copilot Copilot AI review requested due to automatic review settings August 23, 2025 14:56
@github-actions github-actions bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Aug 23, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copy link
Member

@kg kg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I understand this correctly, we still require AdvSIMD on every arm64 target (which makes sense, iirc it's part of the baseline), but we're changing things so LSE is only required on OSX and MacCatalyst and it's allowed to be missing on iOS and tvOS.

@tannergooding
Copy link
Member Author

If I understand this correctly, we still require AdvSIMD on every arm64 target (which makes sense, iirc it's part of the baseline), but we're changing things so LSE is only required on OSX and MacCatalyst and it's allowed to be missing on iOS and tvOS.

@kg, correct. If we have the minimum iOS/tvOS hardware supported then we can likely be a bit more explicit about them as well. But keeping it at the same as .NET 10 will resolve the CI failure for now (I expect iOS is higher than armv8.0-a in particular)

@tannergooding tannergooding merged commit 664eda9 into dotnet:main Aug 23, 2025
161 checks passed
// * tvOSSimulator
//
// For osx-arm64 and maccatalyst, we know that the baseline is apple-m1
// For iOS, tvOS, and the simulator variants it can be older
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: technically for the simulator variants this doesn't apply since they can only run on an m1 mac host.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍, more than happy to update things if we know certain ones support higher.

I expect iOS in practice will also be higher due to the minimum iPhone version supported.

If we have a more explicit set of docs around what the minimums are, I can work on updating and ensuring its properly tested for those targets

@akoeplinger
Copy link
Member

@tannergooding should we backport this?

@tannergooding
Copy link
Member Author

@akoeplinger this was a .NET 11 only change, so there shouldn't be any need to backport.

@tannergooding tannergooding deleted the fix-119008 branch August 26, 2025 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners
Projects
None yet
Development

Successfully merging this pull request may close these issues.

XHarness General Failure in tVOS.Device.Aot.Test
3 participants