Adding GetAssemblyName cDAC API #118875
Merged
Adding GetAssemblyName cDAC API #118875
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR implements the GetAssemblyName cDAC API by adding a native implementation to replace the legacy-only fallback. The implementation retrieves assembly names through the loader contract and includes proper error handling for edge cases.
Key Changes
- Replaced single-line legacy fallback with full cDAC implementation for
GetAssemblyName - Added proper error handling for assemblies without paths (memory-loaded vs reflection emit)
- Included debug validation against legacy implementation for consistency verification
|
Tagging subscribers to this area: @steveisok, @dotnet/dotnet-diag |
max-charlamb
approved these changes
Aug 20, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.