Avoid confusion in Reflection with hidden members. #118709
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR addresses a CoreCLR reflection issue where hidden private/internal members in derived classes can make public members in base classes inaccessible through reflection APIs. The fix removes duplicate filtering logic that was incorrectly filtering out legitimate public members when a derived class uses the new keyword to hide them.
- Removes duplicate property filtering logic in CoreCLR's RuntimeType class
- Adds comprehensive tests for both property and method reflection scenarios with hidden members
- Ensures public base class members remain accessible via reflection even when hidden by derived class members
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/coreclr/System.Private.CoreLib/src/System/RuntimeType.CoreCLR.cs | Removes duplicate filtering logic that prevented access to hidden public properties |
| src/libraries/System.Runtime/tests/System.Reflection.Tests/PropertyInfoTests.cs | Adds test cases and test classes to verify hidden public properties remain accessible |
| src/libraries/System.Runtime/tests/System.Reflection.Tests/MethodInfoTests.cs | Adds test cases and test classes to verify hidden public methods remain accessible |
AaronRobinsonMSFT
added
the
breaking-change
dotnet-policy-service
bot
added
the
needs-breaking-change-doc-created
|
Added When you commit this breaking change:
Tagging @dotnet/compat for awareness of the breaking change. |
jkotas
reviewed
Aug 13, 2025
src/libraries/System.Runtime/tests/System.Reflection.Tests/PropertyInfoTests.cs
Outdated
Show resolved
Hide resolved
jkotas
reviewed
Aug 13, 2025
src/libraries/System.Runtime/tests/System.Reflection.Tests/PropertyInfoTests.cs
Outdated
Show resolved
Hide resolved
This was referenced Aug 14, 2025
This is a narrow change to address a user reported issue on System.Runtime and the common implementation detail, System.RuntimeType.
AaronRobinsonMSFT
force-pushed
the
runtime_118677
branch
from
df89e40 to
005426d
Compare
AaronRobinsonMSFT
requested review from
steveisok,
vitek-karas and
MichalStrehovsky
as code owners
|
I'm closing this issue for now. It is going to require additional discussion for fixes to the underlying issue with Reflection. |
This was referenced Aug 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On CoreCLR, the Reflection API was preemptively
filtering out members with the same name and signature.
This means that hidden private members in C# using
the new keyword in derived classes can make public
members in base classes inaccessible.
Add tests for properties and methods.
Fixes #28056
Fixes #98533
Fixes #118677