Revert "Increase cost of ARR_LENGTH node to match IND(ADD(..,CNS)) #117531 #118707
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…otnet#117531)" This reverts commit 5c17036.
There was a problem hiding this comment.
Pull Request Overview
This PR reverts a previous change that increased the cost of ARR_LENGTH nodes to match IND(ADD(..,CNS)) operations. The revert addresses a performance regression where despite PerfScore improvements, actual benchmark results showed more regressions than improvements.
Key Changes:
- Reverts cost calculation for array metadata operations (ARR_LENGTH and MDARR_LOWER_BOUND)
- Reduces costEx from
IND_COST_EX + 1back toIND_COST_EX - 1 - Reduces costSz from
2 * 2back to2
github-actions
bot
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
|
@dotnet/jit-contrib PTAL revert |
AndyAyersMS
approved these changes
Aug 14, 2025
This was referenced Aug 14, 2025
This was referenced Aug 19, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 5c17036.
Fixes #117938 regression
Despite having a large PerfScore improvements only 1 benchmark improved and 5 regressed.