Update JIT interface to help reduce shared stubs #118462
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to reduce the need for shared stubs, we need some additional information for vararg signatures.
There was a problem hiding this comment.
Pull Request Overview
This PR modifies the JIT interface to add a CORINFO_METHOD_HANDLE parameter to the getVarArgsHandle method, providing additional context for vararg signatures to help reduce the need for shared stubs.
Key changes:
- Added
CORINFO_METHOD_HANDLE methHndparameter togetVarArgsHandlemethod signature - Updated all implementations and wrappers to pass through the new parameter
- Updated versioning GUID to reflect the interface change
Reviewed Changes
Copilot reviewed 17 out of 17 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/coreclr/inc/corinfo.h | Updated the interface definition to include the new method handle parameter |
| src/coreclr/vm/jitinterface.cpp | Modified the main implementation to accept the new parameter and pass NULL in the P/Invoke case |
| src/coreclr/jit/importercalls.cpp | Updated the JIT call site to pass the method handle |
| src/coreclr/tools/superpmi/* | Updated all SuperPMI-related files to handle the new parameter in recording/replaying |
| src/coreclr/tools/aot/jitinterface/* | Updated AOT JIT interface files to support the new parameter |
| src/coreclr/tools/Common/JitInterface/* | Updated common JIT interface implementations for the new signature |
| src/coreclr/inc/jiteeversionguid.h | Updated the JIT/EE version GUID to reflect the interface change |
jkotas
reviewed
Aug 6, 2025
src/coreclr/tools/Common/JitInterface/ThunkGenerator/ThunkInput.txt
Outdated
Show resolved
Hide resolved
jkotas
reviewed
Aug 6, 2025
jkotas
approved these changes
Aug 6, 2025
|
(@dotnet/jit-contrib should sign-off as well.) |
EgorBo
approved these changes
Aug 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to reduce the need for shared stubs, we
need some additional information for vararg
signatures.
See #117901 for use case.