[API Proposal]: Implement IParsable<TSelf> et cetera on IPEndPoint #118095
+418
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-policy-service
bot
added
the
community-contribution
|
Tagging subscribers to this area: @dotnet/ncl |
|
Hey @pedrobsaila, we are past feature complete for 10.0. So this PR cannot be merged until we branch out and main becomes .NET 11. Please do continue work on the PR, I'll find someone to be responsible for the review. Just letting you know about the state of things right now. |
ManickaP
reviewed
Aug 6, 2025
src/libraries/System.Net.Primitives/src/System/Net/IPEndPoint.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Net.Primitives/tests/FunctionalTests/IPEndPointTest.cs
Outdated
Show resolved
Hide resolved
ManickaP
approved these changes
Aug 25, 2025
src/libraries/System.Net.Primitives/tests/FunctionalTests/IPEndPointParsing.cs
Outdated
Show resolved
Hide resolved
MihaZupan
reviewed
Aug 25, 2025
| } | ||
|
|
||
| result = null; | ||
| return false; | ||
| } | ||
|
|
||
| public static bool TryParse(ReadOnlySpan<char> s, [NotNullWhen(true)] out IPEndPoint? result) => InternalTryParse(s, out result); |
There was a problem hiding this comment.
Please also include /// comments on all the new APIs (they seed the api docs)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #114405