-
Notifications
You must be signed in to change notification settings - Fork 5.3k
Delete DEFAULT_STACK_SIZE
#118057
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Delete DEFAULT_STACK_SIZE
#118057
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes the deprecated DEFAULT_STACK_SIZE property bag functionality from the CoreCLR runtime. The change eliminates legacy code that parsed stack size configuration through the host property bag mechanism.
- Removes the
ParseDefaultStackSizefunction and related static variable - Eliminates property bag parsing for
DEFAULT_STACK_SIZEin the host creation process - Simplifies stack size determination to use only environment variables and configuration values
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/coreclr/vm/threads.cpp | Removes ParseDefaultStackSize function, static variable, and simplifies GetDefaultStackSizeSetting logic |
| src/coreclr/vm/corhost.cpp | Removes property bag parsing for DEFAULT_STACK_SIZE during app domain creation |
|
Tagging subscribers to this area: @mangod9 |
|
LGTM, I thought we had an environment variable called |
|
This probably won't make .NET 10 anymore. ASP.NET repo is still on a dotnet/runtime that doesn't support the documented replacement so I can't replace the use of this with the new one. The flow is blocked on dotnet/aspnetcore#63109. It's probably fine... |
#110455 (comment)