Delete dead code in H3StaticTable #117955
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR removes unused code from the H3StaticTable class by deleting the HTTP method index dictionary and related functionality. The change simplifies the codebase by eliminating dead code that is not referenced by Http or ASP.NET components.
- Removes the
s_methodIndexstatic dictionary that mapped HTTP methods to indices - Removes the
MethodIndexpublic property that exposed the dictionary - Removes the unused
System.Collections.Genericusing statement
|
Tagging subscribers to this area: @dotnet/ncl |
liveans
approved these changes
Jul 23, 2025
This was referenced Jul 23, 2025
Open
ManickaP
approved these changes
Jul 23, 2025
|
/ba-g Build analysis isn't picking up WASM queue timeouts |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doesn't appear to be used by Http nor ASP.NET