Skip to content

[release/8.0-staging] [Test Only] Fix BuildChainCustomTrustStore test #117762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 21, 2025
Merged

[release/8.0-staging] [Test Only] Fix BuildChainCustomTrustStore test #117762

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7af82a0
Fix BuildChainCustomTrustStore
vcsjones Jul 16, 2025
5282dc9
Allow partial chains
vcsjones Jul 16, 2025
47849a1
Try using the extra store
vcsjones Jul 16, 2025
cae747c
Fix typo
vcsjones Jul 16, 2025
e77cec6
Allow untrusted root
vcsjones Jul 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion src/libraries/System.Security.Cryptography/tests/X509Certificates/ChainTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -344,6 +344,8 @@ public static void BuildChainCustomTrustStore(
chainTest.ChainPolicy.TrustMode = X509ChainTrustMode.CustomRootTrust;
chainTest.ChainPolicy.ExtraStore.Add(issuerCert);

X509ChainStatusFlags allowedFlags = X509ChainStatusFlags.NoError;

switch (testArguments)
{
case BuildChainCustomTrustStoreTestArguments.TrustedIntermediateUntrustedRoot:
Expand All @@ -361,14 +363,21 @@ public static void BuildChainCustomTrustStore(
chainHolder.DisposeChainElements();
chainTest.ChainPolicy.CustomTrustStore.Remove(rootCert);
chainTest.ChainPolicy.TrustMode = X509ChainTrustMode.System;
chainTest.ChainPolicy.VerificationFlags = X509VerificationFlags.AllowUnknownCertificateAuthority;
chainTest.ChainPolicy.ExtraStore.Add(rootCert);
allowedFlags |= X509ChainStatusFlags.UntrustedRoot;
break;
default:
throw new InvalidDataException();
}

Assert.Equal(chainBuildsSuccessfully, chainTest.Build(endCert));
Assert.Equal(3, chainTest.ChainElements.Count);
Assert.Equal(chainFlags, chainTest.AllStatusFlags());

X509ChainStatusFlags actualFlags = chainTest.AllStatusFlags();
actualFlags &= ~allowedFlags;

Assert.Equal(chainFlags, actualFlags);
}
}

Expand Down
Loading