GetAssemblyModuleList cDAC implementation

[rcj1]

Adding the implementation of the GetAssemblyModuleList API to the cDAC

[Copilot]

Pull Request Overview

Adds the cDAC implementation for GetAssemblyModuleList and extends the loader contracts to support fetching a module pointer from an assembly reference.

• Implements ISOSDacInterface.GetAssemblyModuleList in SOSDacImpl.cs with argument validation, loader dispatch, HRESULT mapping, and debug-time consistency checks against the legacy DAC.
• Introduces a new GetModulePointer method on the ILoader interface (abstraction and contract) and provides its implementation in Loader_1.cs.
• Updates interface definitions in ILoader.cs to include the new API.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File	Description
src/native/managed/cdac/mscordaccore_universal/Legacy/SOSDacImpl.cs	Full implementation of GetAssemblyModuleList, including error handling and DEBUG assertions
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Contracts/Loader_1.cs	Implements ILoader.GetModulePointer, throwing on null or missing module
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Abstractions/Contracts/ILoader.cs	Adds default interface method GetModulePointer to the loader abstraction

Comments suppressed due to low confidence (2)

src/native/managed/cdac/mscordaccore_universal/Legacy/SOSDacImpl.cs:228

• Add unit tests for GetAssemblyModuleList covering edge cases (null/zero assembly, zero count, and assemblies with multiple modules) to validate the new implementation.

    int ISOSDacInterface.GetAssemblyModuleList(ClrDataAddress assembly, uint count, [In, MarshalUsing(CountElementName = "count"), Out] ClrDataAddress[] modules, uint* pNeeded)

src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Abstractions/Contracts/ILoader.cs:80

• [nitpick] The new GetModulePointer interface method lacks XML doc comments. Consider adding a summary and parameter/return descriptions to maintain documentation consistency.

    TargetPointer GetModulePointer(TargetPointer assemblyPointer) => throw new NotImplementedException();

[max-charlamb]

Code changes lgtm 👍
After the runtime-diagnostics pipeline passes lets merge this.