Skip to content

Don't pass -os twice for windows in DotNetBuild.props #114732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 16, 2025
Merged

Don't pass -os twice for windows in DotNetBuild.props #114732

merged 1 commit into from
Apr 16, 2025

Conversation

@akoeplinger
Copy link
Member

@akoeplinger akoeplinger commented Apr 16, 2025

Fixes this error in dotnet/sdk#48477:

D:\a\_work\1\vmr\src\runtime\eng\build.ps1 : Cannot bind parameter because parameter 'os' is specified more than once.

Copilot AI reviewed Apr 16, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (1)
  • eng/DotNetBuild.props: Language not supported

@ghost ghost added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Apr 16, 2025
@ViktorHofer
Copy link
Member

ViktorHofer commented Apr 16, 2025

/ba-g failures unrelated. This file isn't exercised in CI.

@ViktorHofer ViktorHofer merged commit d4628a6 into main Apr 16, 2025
142 of 151 checks passed
@ViktorHofer ViktorHofer deleted the akoeplinger-patch-2 branch April 16, 2025 11:56
This was referenced Apr 16, 2025
Open
Open
Open
Open
Closed
Open
@github-actions github-actions bot locked and limited conversation to collaborators May 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

Copilot code review Copilot Copilot left review comments

@ViktorHofer ViktorHofer ViktorHofer approved these changes

@jkoritzinsky jkoritzinsky Awaiting requested review from jkoritzinsky

Assignees

@akoeplinger akoeplinger

Labels

needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@akoeplinger @ViktorHofer