Fix handling of empty RUNTIME_FUNCTIONs sections in R2R #114091
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Do not set RVA for empty RUNTIME_FUNCTION section in crossgen2 - Do not register empty RUNTIME_FUNCTIONs section at runtime Fixes dotnet#113117
ghost
added
the
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the handling of empty RUNTIME_FUNCTION sections in ReadyToRun by ensuring that an RVA is not set and an empty section is not registered.
- Added a condition to check that the runtime functions table is non-empty before assigning the exception table.
- Prevents registration of empty RUNTIME_FUNCTION sections at runtime.
Files not reviewed (1)
- src/coreclr/vm/peimagelayout.cpp: Language not supported
This was referenced Apr 1, 2025
kg
approved these changes
Apr 1, 2025
|
/ba-g Networking tests |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #113117