Skip to content

Revert gen-buildsys.sh cmake command echo #112929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 25, 2025
Merged

Revert gen-buildsys.sh cmake command echo #112929

merged 1 commit into from
Feb 25, 2025

Conversation

@steveisok
Copy link
Member

@steveisok steveisok commented Feb 25, 2025

This change seems to have impacted wasi on the official build.

@steveisok
Revert gen-buildsys.sh cmake command echo
589215e 
Suspect it broke the wasi official build somehow.
Copilot AI review requested due to automatic review settings February 25, 2025 22:52
Copilot AI reviewed Feb 25, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

@ghost ghost added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Feb 25, 2025
@steveisok steveisok requested a review from a team February 25, 2025 22:52
@steveisok steveisok merged commit 80b0e17 into dotnet:main Feb 25, 2025
4 checks passed
@steveisok steveisok deleted the revert-cmake-echo branch February 25, 2025 22:57
@github-actions github-actions bot locked and limited conversation to collaborators Mar 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

Copilot code review Copilot Copilot left review comments

@jkoritzinsky jkoritzinsky jkoritzinsky approved these changes

@hoyosjs hoyosjs hoyosjs approved these changes

Assignees

@steveisok steveisok

Labels

needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@steveisok @jkoritzinsky @hoyosjs