SPMI: Include JIT-EE GUID changes in JIT baseline detection #112820
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fb67dba changed the JIT-EE GUID, but it includes no changes under src/coreclr/jit/*. The result is that jitrollingbuild built a JIT on that version but overrode the JIT on the parent commit 7060c62 with it. That means the JIT for 7060c62 now has a wrong JIT-EE GUID. Fix the baseline detection so that it includes changes in the JIT-EE GUID. Also log the GUIDs when there is a mismatch in SPMI.
ghost
added
the
area-CodeGen-coreclr
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
EgorBo
approved these changes
Feb 22, 2025
Member
EgorBo
left a comment
EgorBo
left a comment
There was a problem hiding this comment.
I vaguely remember we hit this in the past, I though we fixed it
EgorBo
reviewed
Feb 22, 2025
| # Enumerate the last 20 changes, starting with the baseline, that included JIT changes. | ||
| command = [ "git", "log", "--pretty=format:%H", baseline_hash, "-20", "--", "src/coreclr/jit/*" ] | ||
| # Enumerate the last 20 changes, starting with the baseline, that included JIT and JIT-EE GUID changes. | ||
| command = [ "git", "log", "--pretty=format:%H", baseline_hash, "-20", "--", "src/coreclr/jit/*", "src/coreclr/inc/jiteeversionguid.h" ] |
Member
There was a problem hiding this comment.
does git log support multiple paths?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fb67dba changed the JIT-EE GUID, but it includes no changes under src/coreclr/jit/*. The result is that jitrollingbuild built a JIT on that version but overrode the JIT on the parent commit 7060c62 with it. That means the JIT for 7060c62 now has a wrong JIT-EE GUID.
Fix the baseline detection so that it includes changes in the JIT-EE GUID. Also log the GUIDs when there is a mismatch in SPMI.