Skip to content

[browser] Remove experimental args from NodeJS WBT runner #111655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 10, 2025
Merged

[browser] Remove experimental args from NodeJS WBT runner #111655

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6b22910
[browser] Remove experimental args from NodeJS WBT runner
maraf Jan 21, 2025
dfb019d
Remove experimental args from other places
maraf Feb 3, 2025
edbf9be
Merge branch 'release/9.0-staging' into maraf/BrowserWbtNoExperimenta…
lewing Feb 9, 2025
c9093c8
Skip the ConfigSrcAbsolutePath on NodeJS
maraf Feb 10, 2025
4a93026
Merge branch 'maraf/BrowserWbtNoExperimentalNodeJS' of https://github…
maraf Feb 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/mono/wasm/Wasm.Build.Tests/HostRunner/NodeJSHostRunner.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@ namespace Wasm.Build.Tests;
public class NodeJSHostRunner : IHostRunner
{
public string GetTestCommand() => "wasm test";
public string GetXharnessArgsWindowsOS(XHarnessArgsOptions options) => $"--js-file={options.jsRelativePath} --engine=NodeJS -v trace --engine-arg=--experimental-wasm-simd --engine-arg=--experimental-wasm-eh";
public string GetXharnessArgsOtherOS(XHarnessArgsOptions options) => $"--js-file={options.jsRelativePath} --engine=NodeJS -v trace --locale={options.environmentLocale} --engine-arg=--experimental-wasm-simd --engine-arg=--experimental-wasm-eh";
public string GetXharnessArgsWindowsOS(XHarnessArgsOptions options) => $"--js-file={options.jsRelativePath} --engine=NodeJS -v trace";
public string GetXharnessArgsOtherOS(XHarnessArgsOptions options) => $"--js-file={options.jsRelativePath} --engine=NodeJS -v trace --locale={options.environmentLocale}";
public bool UseWasmConsoleOutput() => true;
public bool CanRunWBT() => true;
}
Loading