Skip to content

Complex Rune enumeration over spans of UTF-16 and UTF-8 text #111170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Sep 24, 2025
Merged

Complex Rune enumeration over spans of UTF-16 and UTF-8 text #111170

merged 10 commits into from
Sep 24, 2025

Conversation

AlexRadch
Copy link
Contributor

Close #28507

AlexRadch added 5 commits June 22, 2023 20:19
@AlexRadch
Added RunePosition
5e187c0
@AlexRadch
Revert solution file
e43112a
@AlexRadch
Code review
ae28635
@AlexRadch
Merge remote-tracking branch 'remotes/upstream/main' into RunePosition
fcdb84e
@AlexRadch
RunePosition code review
8cb6671 
- Modified constructor to be `internal` and updated property assignments.
- Enhanced `Equals` and `GetHashCode` methods for readability and performance.
- Improved XML documentation for clarity and consistency with Unicode terminology.
- Updated test methods to reflect changes in `RunePosition`, removing unnecessary assertions and adding new test cases.
- Ensured enumerators correctly handle current position in Unicode data.
@ghost
Copy link

ghost commented Jan 7, 2025

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

1 similar comment
@ghost
Copy link

ghost commented Jan 7, 2025

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Jan 7, 2025
This was referenced Jan 7, 2025
Open
Open
Closed
lilinus
lilinus reviewed Jan 8, 2025
View reviewed changes
lilinus
lilinus reviewed Jan 8, 2025
View reviewed changes
@AlexRadch
Added implementation of IEnumerator<System.Text.RunePosition> to `U…
d726970 
…tf16Enumerator` and `Utf8Enumerator` structures.
@AlexRadch AlexRadch requested a review from lilinus January 9, 2025 11:31
@build-analysis build-analysis bot mentioned this pull request Jan 9, 2025
Closed
3 tasks
@stephentoub stephentoub requested review from GrabYourPitchforks and removed request for lilinus June 2, 2025 13:11
@stephentoub
Copy link
Member

@GrabYourPitchforks, can you please review this? Thanks.

@jeffhandley jeffhandley requested a review from tarekgh September 1, 2025 19:19
@Joy-less Joy-less mentioned this pull request Sep 5, 2025
Merged
@tarekgh
Copy link
Member

tarekgh commented Sep 22, 2025 •
edited
Loading

@AlexRadch Looks we need to expose the APIs from runtime ref https://github.com/dotnet/runtime/blob/8aa695c0d7b51296ae169dec8ab63a30e129b391/src/libraries/System.Runtime/ref/System.Runtime.cs#L15651. Why we exposing it from System.Memory?

CC @stephentoub @GrabYourPitchforks

tarekgh
tarekgh reviewed Sep 22, 2025
View reviewed changes
tarekgh
tarekgh reviewed Sep 22, 2025
View reviewed changes
tarekgh
tarekgh reviewed Sep 22, 2025
View reviewed changes
tarekgh
tarekgh reviewed Sep 22, 2025
View reviewed changes
tarekgh
tarekgh reviewed Sep 22, 2025
View reviewed changes
@build-analysis build-analysis bot mentioned this pull request Sep 24, 2025
Open
@tarekgh
Copy link
Member

tarekgh commented Sep 24, 2025

/ba-g the failure looks more infrastructure, for sure is not related to the changes here.

@tarekgh tarekgh added this to the 11.0.0 milestone Sep 24, 2025
@tarekgh tarekgh merged commit eae73b7 into dotnet:main Sep 24, 2025
142 of 144 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tarekgh tarekgh tarekgh approved these changes

@GrabYourPitchforks GrabYourPitchforks Awaiting requested review from GrabYourPitchforks

+1 more reviewer

@lilinus lilinus lilinus left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@tarekgh tarekgh

Labels

area-System.Memory community-contribution Indicates that the PR has been added by a community member new-api-needs-documentation

Projects

None yet

Milestone

11.0.0

Development

Successfully merging this pull request may close these issues.

API proposal: Complex Rune enumeration over spans of UTF-16 and UTF-8 text

4 participants

@AlexRadch @stephentoub @tarekgh @lilinus