Add numerical ordering option for string comparison operations #109861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

PranavSenthilnathan merged 9 commits into dotnet:main from PranavSenthilnathan:logical-str-cmp

Nov 25, 2024

Merged

Add numerical ordering option for string comparison operations #109861

move platform check after argument check

Build Analysis / Build Analysis succeeded Nov 25, 2024 in 0s

.NET Result Analysis

Details

Tip

To unconditionally bypass the build analysis check (turn it green), you can use the escape mechanism feature. The completion time may vary, potentially taking several minutes, depending on the build analysis workload at the moment.

⚠️ The following pipeline(s) will not be analyzed as has been explicited excluded from analysis

Known test errors

WasmTestOnChrome-MT-System.Runtime.Tests.WorkItemExecution

[browser][MT] test failure: Tests timed out. Killing driver service

WasmTestOnChrome-MT-System.Runtime.Tests.WorkItemExecution

[8.0][browser][wasm] Failed trying to read log messages via selenium: OpenQA.Selenium.WebDriverException: An unknown exception was encountered sending an HTTP request to the remote WebDriver server for URL

Microsoft.Extensions.Logging.Console.Test.ConsoleLoggerTest.ConsoleLoggerOptions_DisableColors_IsReadFromLoggingConfiguration

[wasm][mt] fail: System.TypeLoadException: Could not load type of field"

Microsoft.Extensions.Logging.Console.Test.ConsoleLoggerTest.ConsoleLoggerOptions_LogAsErrorLevel_IsReadFromLoggingConfiguration

[wasm][mt] fail: System.TypeLoadException: Could not load type of field"

Microsoft.Extensions.Logging.Console.Test.ConsoleLoggerTest.ConsoleLoggerOptions_TimeStampFormat_IsReadFromLoggingConfiguration

[wasm][mt] fail: System.TypeLoadException: Could not load type of field"

Microsoft.Extensions.Logging.Console.Test.ConsoleLoggerTest.ConsoleLoggerOptions_IncludeScopes_IsReadFromLoggingConfiguration

[wasm][mt] fail: System.TypeLoadException: Could not load type of field"

Microsoft.Extensions.Logging.Console.Test.ConsoleLoggerConfigureOptions.ConsoleLoggerConfigureOptions_InvalidConfigurationData

[wasm][mt] fail: System.TypeLoadException: Could not load type of field"

Microsoft.Extensions.Logging.Console.Test.ConsoleLoggerConfigureOptions.EnsureConsoleLoggerOptions_ConfigureOptions_SupportsAllProperties

[wasm][mt] fail: System.TypeLoadException: Could not load type of field"

Microsoft.Extensions.Logging.Console.Test.ConsoleLoggerExtensionsTests.AddConsole_NullFormatterNameUsingSystemdFormat_AnyDeprecatedPropertiesOverwriteFormatterOptions

[wasm][mt] fail: System.TypeLoadException: Could not load type of field"

Microsoft.Extensions.Logging.Console.Test.ConsoleLoggerExtensionsTests.AddJsonConsole_ChangeProperties_IsReadFromLoggingConfiguration

[wasm][mt] fail: System.TypeLoadException: Could not load type of field"

Microsoft.Extensions.Logging.Console.Test.ConsoleLoggerExtensionsTests.AddSimpleConsole_ChangeProperties_IsReadFromLoggingConfiguration

[wasm][mt] fail: System.TypeLoadException: Could not load type of field"

Microsoft.Extensions.Logging.Console.Test.ConsoleLoggerExtensionsTests.AddConsole_FormatterNameIsSet_UsingDefaultFormat_IgnoreDeprecatedAndUseFormatterOptionsInstead

[wasm][mt] fail: System.TypeLoadException: Could not load type of field"

Microsoft.Extensions.Logging.Console.Test.ConsoleLoggerExtensionsTests.AddSimpleConsole_OutsideConfig_TakesProperty

[wasm][mt] fail: System.TypeLoadException: Could not load type of field"

Microsoft.Extensions.Logging.Console.Test.ConsoleLoggerExtensionsTests.AddConsole_NullFormatterName_UsingSystemdFormat_IgnoreFormatterOptionsAndUseDeprecatedInstead

[wasm][mt] fail: System.TypeLoadException: Could not load type of field"

Microsoft.Extensions.Logging.Console.Test.ConsoleLoggerExtensionsTests.AddConsole_MaxQueueLengthLargerThanZero_ConfiguredProperly

[wasm][mt] fail: System.TypeLoadException: Could not load type of field"

Microsoft.Extensions.Logging.Console.Test.ConsoleLoggerExtensionsTests.AddConsoleFormatter_CustomFormatter_IsReadFromLoggingConfiguration

[wasm][mt] fail: System.TypeLoadException: Could not load type of field"

Microsoft.Extensions.Logging.Console.Test.ConsoleLoggerExtensionsTests.AddSystemdConsole_OutsideConfig_TakesProperty

[wasm][mt] fail: System.TypeLoadException: Could not load type of field"

Microsoft.Extensions.Logging.Console.Test.ConsoleLoggerExtensionsTests.AddSystemdConsole_ChangeProperties_IsReadFromLoggingConfiguration

[wasm][mt] fail: System.TypeLoadException: Could not load type of field"

Microsoft.Extensions.Logging.Console.Test.ConsoleLoggerExtensionsTests.EnsureFormatterOptions_OnlyHaveSimpleProperties

[wasm][mt] fail: System.TypeLoadException: Could not load type of field"

Microsoft.Extensions.Logging.Console.Test.ConsoleLoggerExtensionsTests.AddConsole_ConsoleLoggerOptionsFromConfigFile_IsReadFromLoggingConfiguration

[wasm][mt] fail: System.TypeLoadException: Could not load type of field"

Microsoft.Extensions.Logging.Console.Test.ConsoleLoggerExtensionsTests.AddJsonConsole_OutsideConfig_TakesProperty

[wasm][mt] fail: System.TypeLoadException: Could not load type of field"

Microsoft.Extensions.Logging.Console.Test.ConsoleLoggerExtensionsTests.AddConsole_FormatterNameIsSet_UsingSystemdFormat_IgnoreDeprecatedAndUseFormatterOptionsInstead

[wasm][mt] fail: System.TypeLoadException: Could not load type of field"

Microsoft.Extensions.Logging.Console.Test.ConsoleLoggerExtensionsTests.AddConsole_MaxQueueLengthSetToNegativeOrZero_Throws

[wasm][mt] fail: System.TypeLoadException: Could not load type of field"

Microsoft.Extensions.Logging.Console.Test.ConsoleLoggerExtensionsTests.AddConsole_NullFormatterName_UsingDefaultFormat_IgnoreFormatterOptionsAndUseDeprecatedInstead

[wasm][mt] fail: System.TypeLoadException: Could not load type of field"

Microsoft.Extensions.Logging.Console.Test.SimpleConsoleFormatterTests.Log_LogsCorrectTimestamp

[wasm][mt] fail: System.TypeLoadException: Could not load type of field"

Microsoft.Extensions.Logging.Console.Test.SimpleConsoleFormatterTests.InvalidLogLevel_Throws

[wasm][mt] fail: System.TypeLoadException: Could not load type of field"

Microsoft.Extensions.Logging.Console.Test.JsonConsoleFormatterTests.ShouldContainAggregateExceptions

[wasm][mt] fail: System.TypeLoadException: Could not load type of field"

Microsoft.Extensions.Logging.Console.Test.JsonConsoleFormatterTests.Log_StateAndScopeContainsNullValue_SerializesNull

[wasm][mt] fail: System.TypeLoadException: Could not load type of field"

Microsoft.Extensions.Logging.Console.Test.JsonConsoleFormatterTests.Log_StateAndScopeAreCollections_IncludesMessageAndCollectionValues

[wasm][mt] fail: System.TypeLoadException: Could not load type of field"

Microsoft.Extensions.Logging.Console.Test.JsonConsoleFormatterTests.Log_StateAndScopeContainsFloatingPointType_SerializesValue

[wasm][mt] fail: System.TypeLoadException: Could not load type of field"

Microsoft.Extensions.Logging.Console.Test.JsonConsoleFormatterTests.InvalidLogLevel_Throws

[wasm][mt] fail: System.TypeLoadException: Could not load type of field"

Microsoft.Extensions.Logging.Console.Test.JsonConsoleFormatterTests.Log_IncludeScopes_ContainsDuplicateNamedPropertiesInScope_AcceptableJson

[wasm][mt] fail: System.TypeLoadException: Could not load type of field"

Microsoft.Extensions.Logging.Console.Test.JsonConsoleFormatterTests.Log_ScopeIsIEnumerable_SerializesKeyValuePair

[wasm][mt] fail: System.TypeLoadException: Could not load type of field"

Microsoft.Extensions.Logging.Console.Test.JsonConsoleFormatterTests.Log_StateAndScopeContainsSpecialCaseValue_SerializesValueAsExpected

[wasm][mt] fail: System.TypeLoadException: Could not load type of field"

Microsoft.Extensions.Logging.Console.Test.JsonConsoleFormatterTests.Log_TimestampFormatSet_ContainsTimestamp

[wasm][mt] fail: System.TypeLoadException: Could not load type of field"

Microsoft.Extensions.Logging.Console.Test.JsonConsoleFormatterTests.Log_ExceptionWithMessage_ExtractsInfo

[wasm][mt] fail: System.TypeLoadException: Could not load type of field"

Microsoft.Extensions.Logging.Console.Test.JsonConsoleFormatterTests.Log_NullMessage_LogsWhenMessageIsNotProvided

[wasm][mt] fail: System.TypeLoadException: Could not load type of field"

Microsoft.Extensions.Logging.Console.Test.JsonConsoleFormatterTests.NoLogScope_DoesNotWriteAnyScopeContentToOutput_Json

[wasm][mt] fail: System.TypeLoadException: Could not load type of field"

Microsoft.Extensions.Logging.Console.Test.JsonConsoleFormatterTests.ShouldContainInnerException

[wasm][mt] fail: System.TypeLoadException: Could not load type of field"

Microsoft.Extensions.Logging.Console.Test.JsonConsoleFormatterTests.Log_LogsCorrectTimestamp

[wasm][mt] fail: System.TypeLoadException: Could not load type of field"

Microsoft.Extensions.Logging.Console.Test.ConsoleFormatterTests.Log_LogsCorrectTimestamp

[wasm][mt] fail: System.TypeLoadException: Could not load type of field"

Microsoft.Extensions.Logging.Console.Test.ConsoleFormatterTests.InvalidLogLevel_Throws

[wasm][mt] fail: System.TypeLoadException: Could not load type of field"

WasmTestOnFirefox-MT-Microsoft.Extensions.Logging.Console.Tests.WorkItemExecution

[wasm][mt] fail: System.TypeLoadException: Could not load type of field"

WasmTestOnFirefox-MT-System.Reflection.Metadata.Tests.WorkItemExecution

[wasm][mt] fail: System.TypeLoadException: Could not load type of field"

WasmTestOnFirefox-MT-System.Private.Uri.ExtendedFunctional.Tests.WorkItemExecution

[wasm][mt] fail: System.TypeLoadException: Could not load type of field"

WasmTestOnFirefox-MT-System.Net.Http.Functional.Tests.WorkItemExecution

[browser][MT] System.Net.Http.Functional.Tests failure ("Why are we setting the target on an unoccupied slot?")

_{Was this helpful?}

View more details on Build Analysis