Skip to content

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Nov 1, 2024

Backport of #109454 to release/8.0-staging

/cc @jkoritzinsky

Customer Impact

  • Customer reported
  • Found internally

[Select one or both of the boxes. Describe how this issue impacts customers, citing the expected and actual behaviors and scope of the issue. If customer-reported, provide the issue number.]
The macOS-12 build pools are going away in December, so we need to switch away from them before they are removed to avoid failures in public CI.

Regression

  • Yes
  • No

[If yes, specify when the regression was introduced. Provide the PR or commit if known.]

Testing

[How was the fix verified? How was the issue missed previously? What tests were added?]

CI validation of building on the new build pools.

Risk

[High/Medium/Low. Justify the indication by mentioning how risks were measured and addressed.]

Low: This PR validates that the build continues to work. Additionally, we selected an x64 macOS pool to limit possible churn.

@github-actions github-actions bot requested a review from radical as a code owner November 1, 2024 17:15
@ghost ghost added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Nov 1, 2024
@github-actions github-actions bot force-pushed the backport/pr-109454-to-release/8.0-staging branch from 5149f44 to 8fd8501 Compare November 1, 2024 17:30
Copy link
Member

@jeffschwMSFT jeffschwMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved. we can take this as tell mode.

cc @carlossanlop

@jeffschwMSFT jeffschwMSFT added the Servicing-approved Approved for servicing release label Nov 4, 2024
@jeffschwMSFT jeffschwMSFT added this to the 8.0.x milestone Nov 4, 2024
@jkoritzinsky
Copy link
Member

/ba-g failures are unrelated

@jkoritzinsky jkoritzinsky merged commit 934df87 into release/8.0-staging Nov 4, 2024
182 of 187 checks passed
@jkoritzinsky jkoritzinsky deleted the backport/pr-109454-to-release/8.0-staging branch November 4, 2024 21:29
@github-actions github-actions bot locked and limited conversation to collaborators Dec 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners Servicing-approved Approved for servicing release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants