Fix GetTargetPath hook point #106553
Merged
Fix GetTargetPath hook point #106553
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I noticed that in some environments, the existing hook point (AfterTargets=GetTargetPathWithTargetPlatformMoniker) doesn't work. That resulted in some project compiling against the src instead of the ref assembly. DependsOnTargets + BeforeTargets="GetTargetPath" is is more correct anyway and works as exected.
ghost
added
the
|
Tagging subscribers to this area: @dotnet/area-infrastructure-libraries |
This was referenced Aug 16, 2024
3 tasks
ViktorHofer
added a commit
to dotnet/sdk
that referenced
this pull request
Aug 17, 2024
Same as dotnet/runtime#106553 I noticed that in some environments, the existing hook point (AfterTargets=GetTargetPathWithTargetPlatformMoniker) doesn't run before GetTargetPath. That resulted in some project compiling against the src instead of the ref assembly. DependsOnTargets + BeforeTargets="GetTargetPath" is is more correct anyway and works as exected.
akoeplinger
approved these changes
Aug 19, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that in some environments, the existing hook point (AfterTargets=GetTargetPathWithTargetPlatformMoniker) doesn't run before
GetTargetPath. That resulted in some project compiling against the src instead of the ref assembly.DependsOnTargets + BeforeTargets="GetTargetPath" is is more correct anyway and works as exected.