Skip to content

Conversation

@liveans
Copy link
Member

@liveans liveans commented Jul 26, 2024

Removing EOL Alpine 3.16 from pipeline (image already deleted: dotnet/dotnet-buildtools-prereqs-docker#1078)
Adding Alpine 3.17 for normal runs and 3.20 for extra-platforms to pipeline

/cc @ManickaP

@CarnaViire
Copy link
Member

@liveans

note that the standard test CI will not test the 3.20 addition, it only runs for extra-platforms pipeline (isExtraPlatformsBuild=true) or for outerloop on main branch rolling build or some other specially configured pipelines (includeAllPlatforms=true) -- note the conditions:

- ${{ if or(eq(parameters.jobParameters.isExtraPlatformsBuild, true), eq(parameters.jobParameters.includeAllPlatforms, true)) }}:

and

- ${{ if and(eq(parameters.platform, 'linux_musl_arm64'), or(eq(parameters.jobParameters.isExtraPlatformsBuild, true), eq(parameters.jobParameters.includeAllPlatforms, true))) }}:

@liveans
Copy link
Member Author

liveans commented Jul 26, 2024

@liveans

note that the standard test CI will not test the 3.20 addition, it only runs for extra-platforms pipeline (isExtraPlatformsBuild=true) or for outerloop on main branch rolling build or some other specially configured pipelines (includeAllPlatforms=true) -- note the conditions:

- ${{ if or(eq(parameters.jobParameters.isExtraPlatformsBuild, true), eq(parameters.jobParameters.includeAllPlatforms, true)) }}:

and

- ${{ if and(eq(parameters.platform, 'linux_musl_arm64'), or(eq(parameters.jobParameters.isExtraPlatformsBuild, true), eq(parameters.jobParameters.includeAllPlatforms, true))) }}:

Thanks for the note @CarnaViire, I'm aware of it, but I tried to keep 1 version style for normal runs as we used to have before here.

@CarnaViire
Copy link
Member

There are (at least were) "hacks" to check stuff like this without having to run extra-platforms which is super expensive; let me find a PR where I was in a similar situation

@CarnaViire
Copy link
Member

CarnaViire commented Jul 26, 2024

#94609, namely this commit (that must be reverted after CI runs): 63b8302 -- which basically trims the whole pipeline to a single leg execution exactly on the needed distro @liveans

@CarnaViire
Copy link
Member

CarnaViire commented Jul 26, 2024

Thanks for the note @CarnaViire, I'm aware of it, but I tried to keep 1 version style for normal runs as we used to have before here.

I'm not saying you need to change anything (in the "final form" of the PR), I just want the distro to be verified before the PR is merged (and potentially become a noise in outerloops and extra-platforms)

@liveans
Copy link
Member Author

liveans commented Jul 26, 2024

Tests are passing on all 3 alpine versions. Reverted change back and ready to review.

/cc @CarnaViire

Copy link
Member

@CarnaViire CarnaViire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@carlossanlop carlossanlop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to backport this to 8.0 and/or 6.0?

@dotnet-policy-service
Copy link
Contributor

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

@liveans
Copy link
Member Author

liveans commented Jul 29, 2024

Do we need to backport this to 8.0 and/or 6.0?

I'm not sure about the infra perspective here, but we don't need this PR in 8.0/6.0 for now, as far as I know.

/cc @ManickaP

@liveans liveans merged commit aa49ee2 into dotnet:main Jul 29, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Aug 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants