[mono] Fix LLVMArgWasmVtypeAsScalar when a method doesn't set its return value
#101299
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run runtime-extra-platforms-wasm |
|
No pipelines are associated with this pull request. |
|
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
radekdoulik
reviewed
Apr 19, 2024
|
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
I think we should handle it here, the same way as `LLVMArgVtypeAsScalar`. They differ only in the return type, where the wasm specific one is returning type of the element instead of `int`.
|
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
kotlarmilos
changed the title
LLVMArgWasmVtypeAsScalar when a method doesn't set its return value
lambdageek
reviewed
Apr 22, 2024
This was referenced Apr 22, 2024
Co-authored-by: Aleksey Kliger (λgeek) <[email protected]>
|
/azp run runtime-wasm |
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
|
Azure Pipelines successfully started running 1 pipeline(s). |
…nally include TrimmerRootDescriptor on Apple mobile platforms
|
/azp run runtime-wasm,runtime-extra-platforms |
|
Azure Pipelines successfully started running 2 pipeline(s). |
This was referenced Apr 23, 2024
Closed
3 tasks
|
According to the build analysis, the failures are known and shouldn't be related. The wasm-extra-platforms failures seem to be the same as in https://dev.azure.com/dnceng-public/public/_build?definitionId=151&_a=summary. I've created a tracking issue: #101482 |
radekdoulik
approved these changes
Apr 24, 2024
matouskozak
pushed a commit
to matouskozak/runtime
that referenced
this pull request
Apr 30, 2024
…eturn value (dotnet#101299) * Update mini-llvm.c I think we should handle it here, the same way as `LLVMArgVtypeAsScalar`. They differ only in the return type, where the wasm specific one is returning type of the element instead of `int`. * Include TrimmerRootDescriptor only on Apple mobile platforms * Update src/mono/mono/mini/mini-llvm.c --------- Co-authored-by: Radek Doulik <[email protected]> Co-authored-by: Aleksey Kliger (λgeek) <[email protected]>
michaelgsharp
pushed a commit
to michaelgsharp/runtime
that referenced
this pull request
May 9, 2024
…eturn value (dotnet#101299) * Update mini-llvm.c I think we should handle it here, the same way as `LLVMArgVtypeAsScalar`. They differ only in the return type, where the wasm specific one is returning type of the element instead of `int`. * Include TrimmerRootDescriptor only on Apple mobile platforms * Update src/mono/mono/mini/mini-llvm.c --------- Co-authored-by: Radek Doulik <[email protected]> Co-authored-by: Aleksey Kliger (λgeek) <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR should fix an assertion in cases when a method doesn't set its return value. Additionally, it should fix trimming-related issues introduced in #101104 (comment).
Fixes #101104