Set out parameters to default instead of using SkipInit in Interop generators
#101076
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtschuster
requested review from
AaronRobinsonMSFT,
elinor-fung and
jkoritzinsky
ghost
added
the
jtschuster
changed the title
out parameters to default instead of using SkipInitout parameters to default instead of using SkipInit in Interop generators
jkoritzinsky
approved these changes
Apr 15, 2024
AaronRobinsonMSFT
approved these changes
Apr 15, 2024
...nteropServices/tests/ComInterfaceGenerator.Tests/UnmanagedToManagedCustomMarshallingTests.cs
Show resolved
Hide resolved
matouskozak
pushed a commit
to matouskozak/runtime
that referenced
this pull request
Apr 30, 2024
…generators (dotnet#101076) * Set `out` parameters to default instead of using SkipInit * Assert value after P/Invoke
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #98049
To align with
DllImportbehavior,outparameters forLibraryImportandGeneratedComInterfaceshould be default-initialized, neverSkipInit'ed