Skip to content

Conversation

pavelsavara
Copy link
Member

@pavelsavara pavelsavara commented Apr 3, 2024

  • replace mono_wasm_abort with Module.abort to be able to pass reason string
  • register onAbort and onExit also on worker
  • improve stack trace reporting across threads
  • _emscripten_force_exit if the UI thread is spin-waiting
    • trigger it 3000ms after critical mono_wasm_trace_logger like g_assert
    • trigger it 3000ms after nativeAbort
  • fix error formatting
  • max delay for teardown_proxy_console 3000ms
  • only print WASM EXIT on UI thread
  • rename cancelThreads to postCancelThreads
  • move mono_wasm_install_js_worker_interop and mono_wasm_uninstall_js_worker_interop to file worker-interop.ts
  • nativeAbort now also calls terminateAllThreads on UI thread
  • report navigator.userAgent during test-main.js to be able to validate browser version

Contributes to #98309
Contributes to #99888
Contributes to #100249

@pavelsavara pavelsavara added arch-wasm WebAssembly architecture area-System.Runtime.InteropServices.JavaScript os-browser Browser variant of arch-wasm labels Apr 3, 2024
@pavelsavara pavelsavara added this to the 9.0.0 milestone Apr 3, 2024
@pavelsavara pavelsavara self-assigned this Apr 3, 2024
Copy link
Contributor

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

@pavelsavara pavelsavara force-pushed the browser_mt_js_exceptions_2 branch from 556e4b1 to 7dc5c3a Compare April 8, 2024 11:39
@pavelsavara pavelsavara marked this pull request as ready for review April 8, 2024 17:45
@pavelsavara pavelsavara requested a review from lewing as a code owner April 8, 2024 17:45
@pavelsavara pavelsavara requested review from maraf and ilonatommy April 8, 2024 17:46
# Conflicts:
#	src/mono/browser/runtime/pthreads/index.ts
# Conflicts:
#	src/mono/browser/runtime/types/internal.ts
@pavelsavara
Copy link
Member Author

Part of the failures are #100275
I also filed new #100831 which is uncovered by this PR

@pavelsavara pavelsavara merged commit 552b5e9 into dotnet:main Apr 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly architecture area-System.Runtime.InteropServices.JavaScript os-browser Browser variant of arch-wasm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants