[mono] Optimize (typedef|table|declsec)_locator metadata loading #100157
+165
−157
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
This was referenced Mar 22, 2024
Member
Author
|
I don't quite understand the linker error I'm getting on android and tvOS. I assume I need to apply a component API attribute to something, but I'm not sure what or why |
This was referenced Apr 6, 2024
…ng initialization out
This was referenced Apr 10, 2024
lambdageek
approved these changes
Apr 10, 2024
Member
lambdageek
left a comment
lambdageek
left a comment
There was a problem hiding this comment.
lgtm. just some nits about making shared type sand functions.
matouskozak
pushed a commit
to matouskozak/runtime
that referenced
this pull request
Apr 30, 2024
…net#100157) * Optimize typedef_locator, table_locator and declsec_locator by hoisting initialization out * Cleanup duplicated code with different understandings of locator_t
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Metadata loading does a bunch of table searches that contain redundant lookups and checks, this PR attempts to optimize them by hoisting most of the checking and computation outside of the binary search operation.
Profile with this in effect: https://share.firefox.dev/4aqtjUc