Add .slnx support #1662

darthtrevino · 2025-07-01T18:42:53Z

This PR follows up with #1640.

The issues referenced in that PR have all been resolved, but I needed to make a few changes to get slnx parsing working, including:

Bump TargetFramework to net9.0 in the CommandLine project
Bump RoslynVersion to 4.14.0
Include Microsoft.Build in the CommandLine project.

It's been a while since I've worked in a .NET project, so you might want to double-check my changes, and make sure this will work for users in .net 7 and 8 environments.

fixes #1639

darthtrevino · 2025-07-01T18:46:20Z

@dotnet-policy-service agree company="Microsoft"

commit 219124e Author: Chris Trevino <[email protected]> Date: Tue Jul 1 22:02:34 2025 -0700 dotnet format commit f721781 Author: Chris Trevino <[email protected]> Date: Tue Jul 1 21:57:24 2025 -0700 add pragma disable commit b645a59 Author: Chris Trevino <[email protected]> Date: Tue Jul 1 21:47:40 2025 -0700 remove net7.0 targets (deprecated) commit 85b7920 Author: Chris Trevino <[email protected]> Date: Tue Jul 1 21:42:00 2025 -0700 conditional Microsoft.Build import commit 7ce673f Author: Chris Trevino <[email protected]> Date: Tue Jul 1 21:20:28 2025 -0700 drop net7.0 commit f26dd93 Author: Chris Trevino <[email protected]> Date: Tue Jul 1 21:08:32 2025 -0700 update dotnet 9.0.x install commit c8f9262 Author: Chris Trevino <[email protected]> Date: Tue Jul 1 21:02:57 2025 -0700 leave roslynator.sln commit 88581a4 Author: Chris Trevino <[email protected]> Date: Tue Jul 1 20:55:47 2025 -0700 test fix commit 922110c Author: Chris Trevino <[email protected]> Date: Tue Jul 1 20:44:34 2025 -0700 fix lint issue commit 4782f89 Author: Chris Trevino <[email protected]> Date: Tue Jul 1 20:41:52 2025 -0700 fix lint violation commit cf5a4ed Merge: 27d7848 1384df8 Author: Chris Trevino <[email protected]> Date: Tue Jul 1 20:36:51 2025 -0700 Merge branch 'dathtrevino/feat/slnx_support' into task/slnx_everything commit 27d7848 Author: Chris Trevino <[email protected]> Date: Tue Jul 1 11:43:53 2025 -0700 slnx everything

josefpihrt · 2025-07-02T20:07:34Z

Hey @darthtrevino,

Thank your for the PR.

If I may ask you please don't mix support for slnx in command-line tool with migrating this project to slnx. If you would like to migrate this project to slnx please open an issue first and discuss it. Thanks.

darthtrevino · 2025-07-02T21:51:57Z

Yep, sure thing, I'll revert those changes

josefpihrt

Please update changelog, also mentioning that Roslyn version was bumped for CLI (you can find it in changelog mentioned before).

src/CommandLine.DocumentationGenerator/DocumentationWriter.cs

src/Tests/Analyzers.Tests/RCS1213RemoveUnusedMemberDeclarationTests.cs

.github/workflows/build.yml

src/CommandLine.DocumentationGenerator/CommandLine.DocumentationGenerator.csproj

src/CommandLine/CommandLine.csproj

src/CommandLine/Json/DiagnosticGitLabJsonSerializer.cs

…Tests.cs Co-authored-by: Josef Pihrt <[email protected]>

Co-authored-by: Josef Pihrt <[email protected]>

josefpihrt · 2025-08-24T08:43:36Z

@darthtrevino Thanks for the contribution!

…14.1 (#49) Updated [Roslynator.CodeAnalysis.Analyzers](https://github.com/dotnet/roslynator) from 4.14.0 to 4.14.1. <details> <summary>Release notes</summary> _Sourced from [Roslynator.CodeAnalysis.Analyzers's releases](https://github.com/dotnet/roslynator/releases)._ ## 4.14.1 ### Added - [CLI] Add support for `slnx` files ([PR](dotnet/roslynator#1662) by @darthtrevino) - Bump Roslyn to 4.14.0 - Drop support for .NET 7 SDK ### Fixed - Fix analyzer [RCS1246](https://josefpihrt.github.io/docs/roslynator/analyzers/RCS1246) ([PR](dotnet/roslynator#1676)) - Fix analyzer [RCS1248](https://josefpihrt.github.io/docs/roslynator/analyzers/RCS1248) ([PR](dotnet/roslynator#1677)) - Fix analyzer [RCS1203](https://josefpihrt.github.io/docs/roslynator/analyzers/RCS1203) ([PR](dotnet/roslynator#1683)) - Fix analyzer [RCS1043](https://josefpihrt.github.io/docs/roslynator/analyzers/RCS1043) ([PR](dotnet/roslynator#1684)) - Fix analyzer [RCS1213](https://josefpihrt.github.io/docs/roslynator/analyzers/RCS1213) ([PR](dotnet/roslynator#1686)) - Add unity method `OnRectTransformDimensionsChange` - Fix analyzer [RCS1253](https://josefpihrt.github.io/docs/roslynator/analyzers/RCS1253) ([PR](dotnet/roslynator#1687)) - Fix refactoring [Check expression for null](https://josefpihrt.github.io/docs/roslynator/refactorings/RR0024) ([PR](dotnet/roslynator#1682)) ### Changed - Change behavior of analyzer [RCS1206](https://josefpihrt.github.io/docs/roslynator/analyzers/RCS1206) ([PR](dotnet/roslynator#1685)) - The condition for option `omit_when_single_line` will be that the braces/brackets are on the same line, not just the expression in the braces/brackets Commits viewable in [compare view](dotnet/roslynator@v4.14.0...v4.14.1). </details> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=Roslynator.CodeAnalysis.Analyzers&package-manager=nuget&previous-version=4.14.0&new-version=4.14.1)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

….1 (#50) Updated [Roslynator.Formatting.Analyzers](https://github.com/dotnet/roslynator) from 4.14.0 to 4.14.1. <details> <summary>Release notes</summary> _Sourced from [Roslynator.Formatting.Analyzers's releases](https://github.com/dotnet/roslynator/releases)._ ## 4.14.1 ### Added - [CLI] Add support for `slnx` files ([PR](dotnet/roslynator#1662) by @darthtrevino) - Bump Roslyn to 4.14.0 - Drop support for .NET 7 SDK ### Fixed - Fix analyzer [RCS1246](https://josefpihrt.github.io/docs/roslynator/analyzers/RCS1246) ([PR](dotnet/roslynator#1676)) - Fix analyzer [RCS1248](https://josefpihrt.github.io/docs/roslynator/analyzers/RCS1248) ([PR](dotnet/roslynator#1677)) - Fix analyzer [RCS1203](https://josefpihrt.github.io/docs/roslynator/analyzers/RCS1203) ([PR](dotnet/roslynator#1683)) - Fix analyzer [RCS1043](https://josefpihrt.github.io/docs/roslynator/analyzers/RCS1043) ([PR](dotnet/roslynator#1684)) - Fix analyzer [RCS1213](https://josefpihrt.github.io/docs/roslynator/analyzers/RCS1213) ([PR](dotnet/roslynator#1686)) - Add unity method `OnRectTransformDimensionsChange` - Fix analyzer [RCS1253](https://josefpihrt.github.io/docs/roslynator/analyzers/RCS1253) ([PR](dotnet/roslynator#1687)) - Fix refactoring [Check expression for null](https://josefpihrt.github.io/docs/roslynator/refactorings/RR0024) ([PR](dotnet/roslynator#1682)) ### Changed - Change behavior of analyzer [RCS1206](https://josefpihrt.github.io/docs/roslynator/analyzers/RCS1206) ([PR](dotnet/roslynator#1685)) - The condition for option `omit_when_single_line` will be that the braces/brackets are on the same line, not just the expression in the braces/brackets Commits viewable in [compare view](dotnet/roslynator@v4.14.0...v4.14.1). </details> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=Roslynator.Formatting.Analyzers&package-manager=nuget&previous-version=4.14.0&new-version=4.14.1)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Rene Bentes Pinto <[email protected]>

timozn and others added 5 commits March 27, 2025 00:12

Add support for the slnx solution file type

0fa4b9a

Add support for the slnx solution file type

f25c629

fix formatting

8aebb26

add slnx support

498d789

use net9.0 path in some tool scripts

38b5557

darthtrevino and others added 3 commits July 1, 2025 11:46

Merge branch 'main' into dathtrevino/feat/slnx_support

1c8fccb

add setup-dotnet step

1384df8

darthtrevino and others added 4 commits July 2, 2025 14:59

revert slnx changes

34e0c2a

revert a couple of changes

e032d7c

update pragma text

37c7b50

Merge branch 'main' into dathtrevino/feat/slnx_support

bc16d33

josefpihrt self-requested a review July 26, 2025 11:08

josefpihrt mentioned this pull request Jul 26, 2025

Add support for the slnx solution file type #1640

Closed

josefpihrt reviewed Jul 26, 2025

View reviewed changes

josefpihrt and others added 7 commits August 3, 2025 18:23

Merge branch 'main' into dathtrevino/feat/slnx_support

04eec57

Merge branch 'main' into dathtrevino/feat/slnx_support

54d7003

Update src/Tests/Analyzers.Tests/RCS1213RemoveUnusedMemberDeclaration…

48a376b

…Tests.cs Co-authored-by: Josef Pihrt <[email protected]>

Update src/CommandLine.DocumentationGenerator/DocumentationWriter.cs

5f3334a

Co-authored-by: Josef Pihrt <[email protected]>

Merge branch 'main' into dathtrevino/feat/slnx_support

8c58f28

fix tests

5b544fc

update changelog

ffb226c

josefpihrt approved these changes Aug 8, 2025

View reviewed changes

josefpihrt merged commit 6c761a6 into dotnet:main Aug 24, 2025
17 checks passed

This was referenced Oct 6, 2025

Bump Roslynator.Analyzers from 4.14.0 to 4.14.1 trackd/Sixel#38

Merged

Bump Roslynator.CodeFixes from 4.14.0 to 4.14.1 trackd/Sixel#39

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Add .slnx support #1662

Add .slnx support #1662

Uh oh!

darthtrevino commented Jul 1, 2025 •

edited by josefpihrt

Loading

Uh oh!

darthtrevino commented Jul 1, 2025

Uh oh!

josefpihrt commented Jul 2, 2025

Uh oh!

darthtrevino commented Jul 2, 2025

Uh oh!

josefpihrt left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

josefpihrt commented Aug 24, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Add .slnx support #1662

Add .slnx support #1662

Uh oh!

Conversation

darthtrevino commented Jul 1, 2025 • edited by josefpihrt Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

darthtrevino commented Jul 1, 2025

Uh oh!

josefpihrt commented Jul 2, 2025

Uh oh!

darthtrevino commented Jul 2, 2025

Uh oh!

josefpihrt left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

josefpihrt commented Aug 24, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

darthtrevino commented Jul 1, 2025 •

edited by josefpihrt

Loading