Allow Razor to hook up the source generator in misc files #79891

davidwengier · 2025-08-13T07:18:33Z

Part of dotnet/vscode-csharp#8512
Tracked by dotnet/razor#9519 and dotnet/razor#11833

This removes the isRazor hackiness in misc files, and allows Razor to provide a source generator reference to the project. Needs work on Razor not just to implement the service, which is trivial, but because the source generator doesn't actually support misc files at the moment :)

davidwengier · 2025-08-15T06:06:01Z

lol whoops. Have to rebase onto main-vs-deps to test locally, didn't mean to push. Apologies force push :D

…tor has a consistent ALC

davidwengier · 2025-08-15T06:16:55Z

...r/Microsoft.CodeAnalysis.LanguageServer/HostWorkspace/VSCodeAnalyzerLoaderProviderFactory.cs

@@ -11,7 +11,7 @@

 namespace Microsoft.CodeAnalysis.LanguageServer.HostWorkspace;

-[ExportWorkspaceService(typeof(IAnalyzerAssemblyLoaderProvider), [WorkspaceKind.Host]), Shared]
+[ExportWorkspaceService(typeof(IAnalyzerAssemblyLoaderProvider), [WorkspaceKind.Host, WorkspaceKind.MiscellaneousFiles]), Shared]


Just bringing your attention to this change @dibarbet because it was added after your review. Hopefully it's okay because without it we're in a world of ALC pain and suffering :)

seems... fine? mostly just the default loader, except also knows about the extension context.

Yeah, thats all it is. We need the source gen to come from the extension, because otherwise types are different in Razor when we try to actually get out generator bits, because of course all of the handlers come from the extension.

dibarbet · 2025-08-16T00:49:03Z

...r/Microsoft.CodeAnalysis.LanguageServer/HostWorkspace/VSCodeAnalyzerLoaderProviderFactory.cs

@@ -11,7 +11,7 @@

 namespace Microsoft.CodeAnalysis.LanguageServer.HostWorkspace;

-[ExportWorkspaceService(typeof(IAnalyzerAssemblyLoaderProvider), [WorkspaceKind.Host]), Shared]
+[ExportWorkspaceService(typeof(IAnalyzerAssemblyLoaderProvider), [WorkspaceKind.Host, WorkspaceKind.MiscellaneousFiles]), Shared]


seems... fine? mostly just the default loader, except also knows about the extension context.

This reverts commit cc9177a.

This reverts commit 8f35c3f.

…#12106) The Razor side of dotnet/vscode-csharp#8512 Needs dotnet/roslyn#79891 for the interface definition, and to hook things up in the misc files project Fixes #9519 Fixes #11833 This could be done as its own PR without the source generator locator service, and it would all be the same, but also impossible to hit in real life, so I just bundled it all together.

jasonmalinowski · 2025-08-21T22:49:21Z

src/Features/Core/Portable/Workspace/IMiscellaneousProjectInfoService.cs

+
+namespace Microsoft.CodeAnalysis.Features.Workspaces;
+
+internal interface IMiscellaneousProjectInfoService : ILanguageService


Do you imagine this also being used in VS for Windows?

I was hoping to, yes. Did I put something in the wrong place for that to happen?

jasonmalinowski · 2025-08-21T22:53:56Z

src/LanguageServer/Protocol.TestUtilities/AbstractLspMiscellaneousFilesWorkspaceTests.cs

@@ -178,8 +183,10 @@ void M()
    [Theory, CombinatorialData]
    public async Task TestLooseFile_RazorFile(bool mutatingLspWorkspace)
    {
+        var composition = Composition.AddParts(typeof(TestRazorMiscellaneousProjectInfoService));


Should this just be applied to all tests in this file?

46 PRs before and 36 after ```diff + * [Cache diagnostic analyzer computation](dotnet/roslyn#80045) + * [Remove parameter always passed the same value](dotnet/roslyn#80042) * [Update doc for IMethodSymbol.IsExtensionMethod](dotnet/roslyn#80016) * [Don't cache known-broken compositions](dotnet/roslyn#80021) * [Cleanup methods in DiagAnalyzerService](dotnet/roslyn#80013) * [Simplify processing of errors reported by the build](dotnet/roslyn#79964) * [Additional cleanup of the DiagnosticAnalyzerServier](dotnet/roslyn#80005) * [Fix Code Lens around source generated files](dotnet/roslyn#79992) * [Remove superflous DiagService api that can be achieved with existing apis](dotnet/roslyn#80007) * [Generate `init` accessor for required properties inside `readonly struct`s](dotnet/roslyn#80004) * [Remove existing low level diag oop code now that it's all handled at higher levels.](dotnet/roslyn#79994) * [Allow large InlineHint ArrayBuilder pooling](dotnet/roslyn#79857) * [Reduce allocations obtaining classified spans in ClassifierHelper](dotnet/roslyn#79856) * [Compute span diagnostics in oop](dotnet/roslyn#79991) * [Allow Razor cohosting to work with non-Razor SDK projects](dotnet/roslyn#79953) * [Move computation of deprioritized analyzers to oop](dotnet/roslyn#79989) * [EnC: Fix symbol mapping of delegates with indexed name](dotnet/roslyn#79837) * [Emit telemetry 'durations' with known radix point '.'](dotnet/roslyn#79988) * [Move logic up into DiagService](dotnet/roslyn#79985) * [Move the StateManager type up to the DiagnosticService from the DiagnosticIncrementalANalyzer](dotnet/roslyn#79984) * [Immediately remote diagnostics call to OOP](dotnet/roslyn#79983) * [Build Microsoft.CodeAnalysis.SemanticSearch.Extension ref assembly for use in semantic search queries](dotnet/roslyn#79972) * [Only cache compilation if we have the same set of analyzers](dotnet/roslyn#79978) * [Delete unused property](dotnet/roslyn#79963) * [Update 'use expr body' to be a purely syntactic analyzer](dotnet/roslyn#79979) * [Mark 'Use expr body' as a syntax-only fixer](dotnet/roslyn#79971) * [♻️ MSBuildWorkspaceDirectory - Fallback to AppContext.BaseDirectory when Assembly Location is empty](dotnet/roslyn#79934) * [Merge runtime async support into main](dotnet/roslyn#79833) * [Implement "Simplify property accessor" feature](dotnet/roslyn#79754) - * Merge main to runtime async branch (PR: [#79961](dotnet/roslyn#79961)) * [Redo how and when we report source generator telemetry](dotnet/roslyn#79951) * [Allow MEF components to supply assembly path resolvers](dotnet/roslyn#79218) * [Allow Razor to hook up the source generator in misc files](dotnet/roslyn#79891) * [Block ENC for extension blocks](dotnet/roslyn#79883) * [Upgrade servicehub.client to fix test source discovery](dotnet/roslyn#79899) * [Update package restore error message.](dotnet/roslyn#79876) - * Merge main (PR: [#79834](dotnet/roslyn#79834)) - * Merge main (PR: [#79830](dotnet/roslyn#79830)) * [Baseline struct lifting tests](dotnet/roslyn#79505) - * Merge main to runtime async branch (PR: [#79582](dotnet/roslyn#79582)) - * Merge main (PR: [#79424](dotnet/roslyn#79424)) - * Merge main (PR: [#78994](dotnet/roslyn#78994)) - * Merge main to runtime async branch (PR: [#78740](dotnet/roslyn#78740)) - * Merge main to runtime async branch (PR: [#78517](dotnet/roslyn#78517)) - * Merge main to runtime async branch (PR: [#78114](dotnet/roslyn#78114)) - * Merge main to runtime async branch (PR: [#77700](dotnet/roslyn#77700)) - * Merge main to runtime async branch (PR: [#77533](dotnet/roslyn#77533)) - * Merge main to runtime async branch (PR: [#77265](dotnet/roslyn#77265)) ```

Formalize misc files customizations, and add analyzer references support

74a446b

davidwengier requested a review from a team as a code owner August 13, 2025 07:18

github-actions bot added the Area-IDE label Aug 13, 2025

dotnet-policy-service bot added the VSCode label Aug 13, 2025

davidwengier closed this Aug 13, 2025

davidwengier reopened this Aug 14, 2025

davidwengier mentioned this pull request Aug 14, 2025

Allow the source generator to produce results for miscellaneous files dotnet/razor#12106

Merged

Fix test

1dd730f

RikkiGibson self-assigned this Aug 14, 2025

build-analysis bot mentioned this pull request Aug 14, 2025

The active test run was aborted. Reason: Test host process crashed dotnet/dnceng#451

Open

3 tasks

dibarbet approved these changes Aug 14, 2025

View reviewed changes

davidwengier requested a review from a team as a code owner August 15, 2025 04:56

Export the analyzer loader for the Misc workspace so the Razor genera…

86c426e

…tor has a consistent ALC

davidwengier force-pushed the RazorGeneratorForMiscFiles branch from 52ae0f1 to 86c426e Compare August 15, 2025 06:06

davidwengier removed the request for review from a team August 15, 2025 06:07

davidwengier commented Aug 15, 2025

View reviewed changes

dibarbet approved these changes Aug 16, 2025

View reviewed changes

davidwengier added 4 commits August 16, 2025 17:02

Sneak in a sneaky test IVT

8f35c3f

Missed one

cc9177a

Revert "Missed one"

23d12a4

This reverts commit cc9177a.

Revert "Sneak in a sneaky test IVT"

9c7e33f

This reverts commit 8f35c3f.

davidwengier merged commit b7353b8 into dotnet:main Aug 18, 2025
25 checks passed

davidwengier deleted the RazorGeneratorForMiscFiles branch August 18, 2025 21:59

dotnet-policy-service bot added this to the Next milestone Aug 18, 2025

RikkiGibson modified the milestones: Next, 18.0 P1 Aug 19, 2025

dotnet-bot mentioned this pull request Aug 20, 2025

[Automated] PRs inserted in VS build main-10919.87 #79975

Closed

dotnet-bot mentioned this pull request Aug 20, 2025

[Automated] PRs inserted in VS build feature.debugger.main-10919.234 #79982

Closed

jasonmalinowski reviewed Aug 21, 2025

View reviewed changes

dotnet-bot mentioned this pull request Aug 22, 2025

[Automated] PRs inserted in VS build feature.Wix5-10921.95 #80011

Closed

davidwengier mentioned this pull request Aug 25, 2025

Allow Razor cohosting to work with non-Razor SDK projects dotnet/vscode-csharp#8559

Merged

This was referenced Sep 8, 2025

Bump Roslyn to 5.0.0-2.25430.3 (2eaa0989) deepakrathore33/vscode-csharp#1

Closed

Bump Roslyn to 5.0.0-2.25430.3 (2eaa0989) deepakrathore33/vscode-csharp#2

Closed

Bump Roslyn to 5.0.0-2.25430.3 (2eaa0989) deepakrathore33/vscode-csharp#6

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Allow Razor to hook up the source generator in misc files #79891

Allow Razor to hook up the source generator in misc files #79891

Uh oh!

davidwengier commented Aug 13, 2025

Uh oh!

davidwengier commented Aug 15, 2025 •

edited

Loading

Uh oh!

davidwengier Aug 15, 2025

Uh oh!

dibarbet Aug 16, 2025

Uh oh!

davidwengier Aug 16, 2025

Uh oh!

dibarbet Aug 16, 2025

Uh oh!

Uh oh!

jasonmalinowski Aug 21, 2025

Uh oh!

davidwengier Aug 21, 2025

Uh oh!

jasonmalinowski Aug 21, 2025

Uh oh!

Uh oh!


		namespace Microsoft.CodeAnalysis.Features.Workspaces;

		internal interface IMiscellaneousProjectInfoService : ILanguageService

Allow Razor to hook up the source generator in misc files #79891

Allow Razor to hook up the source generator in misc files #79891

Uh oh!

Conversation

davidwengier commented Aug 13, 2025

Uh oh!

davidwengier commented Aug 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

davidwengier Aug 15, 2025

Choose a reason for hiding this comment

Uh oh!

dibarbet Aug 16, 2025

Choose a reason for hiding this comment

Uh oh!

davidwengier Aug 16, 2025

Choose a reason for hiding this comment

Uh oh!

dibarbet Aug 16, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jasonmalinowski Aug 21, 2025

Choose a reason for hiding this comment

Uh oh!

davidwengier Aug 21, 2025

Choose a reason for hiding this comment

Uh oh!

jasonmalinowski Aug 21, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

davidwengier commented Aug 15, 2025 •

edited

Loading