Fix failing test case BindingAsyncTasklikeMoreTests.Dynamic on Mono #79878
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cs.BindingAsyncTasklikeMoreTests.Dynamic on Mono The BindingAsyncTasklikeMoreTests.Dynamic test was failing on Mono because the type of ConstructorArguments differs between Mono and CoreCLR. The existing test expectation was aligned with CoreCLR behavior, which caused mismatches when running under Mono. This change updates the test to set the expected value based on the current runtime.
dotnet-policy-service
bot
added
the
Community
333fred
reviewed
Aug 14, 2025
src/Compilers/CSharp/Test/Semantic/Semantics/BindingAsyncTasklikeMoreTests.cs
Outdated
Show resolved
Hide resolved
333fred
approved these changes
Aug 19, 2025
jaredpar
approved these changes
Aug 19, 2025
|
Thanks @Venkad000! |
This was referenced Aug 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The BindingAsyncTasklikeMoreTests.Dynamic test was failing on Mono because the type of ConstructorArguments differs between Mono and CoreCLR. The existing test expectation was aligned with CoreCLR behavior, which caused mismatches when running under Mono. This change updates the test to set the expected value based on the current runtime.