Avoid adding duplicate suppressors to the host analyzer arrays #77062
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
Area-IDE
untriaged
tmat
reviewed
Feb 5, 2025
src/LanguageServer/Protocol/Features/Diagnostics/DocumentAnalysisExecutor_Helpers.cs
Outdated
Show resolved
Hide resolved
tmat
reviewed
Feb 5, 2025
...Workspaces/SharedUtilitiesAndExtensions/Compiler/Core/Extensions/ImmutableArrayExtensions.cs
Outdated
Show resolved
Hide resolved
...Workspaces/SharedUtilitiesAndExtensions/Compiler/Core/Extensions/ImmutableArrayExtensions.cs
Outdated
Show resolved
Hide resolved
src/LanguageServer/Protocol/Features/Diagnostics/DocumentAnalysisExecutor_Helpers.cs
Outdated
Show resolved
Hide resolved
src/Workspaces/Remote/ServiceHub/Services/DiagnosticAnalyzer/DiagnosticComputer.cs
Outdated
Show resolved
Hide resolved
src/Workspaces/Remote/ServiceHub/Services/DiagnosticAnalyzer/DiagnosticComputer.cs
Outdated
Show resolved
Hide resolved
|
There seems to be a lot of finicky range manipulation here to accomplish what seems to be a simple concept (not adding a dupe of something). I'd prefer a much simpler and more targeted approach here in line with how the rest of the code is structured. |
CyrusNajmabadi
requested changes
Feb 6, 2025
sharwell
force-pushed
the
idempotent-suppressors
branch
from
48295cc to
a0a84e3
Compare
CyrusNajmabadi
approved these changes
Mar 20, 2025
|
Any possibility of a test here? |
This was referenced Mar 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs tests and manual regression validation