Skip to content

Update help link URI for code style diagnostics #64438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 4, 2022
Merged

Update help link URI for code style diagnostics #64438

merged 3 commits into from
Oct 4, 2022

Conversation

mavasani
Copy link
Contributor

@mavasani mavasani commented Oct 3, 2022

Closes #64268

@mavasani
Closes dotnet#64268
1df8032 
Update help link URI for code style diagnostics
@mavasani mavasani requested a review from a team as a code owner October 3, 2022 13:14
@mavasani
Copy link
Contributor Author

mavasani commented Oct 3, 2022

@Youssef1313

Youssef1313
Youssef1313 reviewed Oct 4, 2022
View reviewed changes
Copy link
Member

@Youssef1313 Youssef1313 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider updating:

https://github.com/dotnet/roslyn/blob/main/src/VisualStudio/VisualBasic/Impl/LanguageService/VisualBasicCodeCleanupFixerDiagnosticIds.vb

https://github.com/dotnet/roslyn/blob/main/src/VisualStudio/Core/Def/CodeCleanup/CommonCodeCleanUpFixerDiagnosticIds.cs

https://github.com/dotnet/roslyn/blob/main/src/VisualStudio/CSharp/Impl/LanguageService/CSharpCodeCleanupFixerDiagnosticIds.cs

@mavasani mavasani enabled auto-merge October 4, 2022 14:54
@mavasani mavasani merged commit 2766d28 into dotnet:main Oct 4, 2022
@ghost ghost added this to the Next milestone Oct 4, 2022
@mavasani mavasani deleted the FixDocsLink branch October 5, 2022 09:13
@allisonchou allisonchou mentioned this pull request Oct 11, 2022
Closed
@RikkiGibson RikkiGibson modified the milestones: Next, 17.5 P1 Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonmalinowski jasonmalinowski jasonmalinowski approved these changes

@genlu genlu genlu approved these changes

+1 more reviewer

@Youssef1313 Youssef1313 Youssef1313 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
Area-IDE
Projects
None yet
Milestone
17.5 P1
Development

Successfully merging this pull request may close these issues.

Update docs.microsoft.com links to learn.microsoft.com
5 participants
@mavasani @jasonmalinowski @genlu @Youssef1313 @RikkiGibson