Skip to content

Hot Reload watch service #51967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 22, 2021
Merged

Hot Reload watch service #51967

merged 4 commits into from
Mar 22, 2021

Conversation

tmat
Copy link
Member

@tmat tmat commented Mar 18, 2021 •
edited
Loading

Implements WatchHotReloadService wrapper around IEditAndContinueWorkspaceService that exposes EnC functionality in a shape suitable for dotnet watch.

Adds new capability to StartDebuggingSessionAsync that allows the EnC service to hydrate the content of files that support EnC in the given solution snapshot and checks that the sources match the checksums stored in the PDB. Matching document ids are cached so that the validation does not need to be redone when emitting deltas later on.

Implements #50773

@ghost ghost added the Area-Interactive label Mar 18, 2021
@tmat tmat force-pushed the WatchExternalAccess branch from baa123c to 48b5a09 Compare March 19, 2021 20:29
@tmat tmat force-pushed the WatchExternalAccess branch from 48b5a09 to 8a03b63 Compare March 19, 2021 20:34
@tmat tmat marked this pull request as ready for review March 19, 2021 20:35
@tmat tmat requested a review from a team as a code owner March 19, 2021 20:35
@tmat
Copy link
Member Author

tmat commented Mar 19, 2021

@davidwengier @pranavkm

@pranavkm
Copy link
Contributor

Did you miss adding WatchHotReloadService to this? Also I don't think these changes are in main as yet: https://github.com/dotnet/roslyn/tree/main-vs-deps/src/Tools/ExternalAccess/DotNetWatch

@tmat
Copy link
Member Author

tmat commented Mar 19, 2021

@pranavkm Ah, yes. Sadly git commit -am does not commit new files :(

@tmat tmat merged commit b254587 into dotnet:main Mar 22, 2021
@ghost ghost added this to the Next milestone Mar 22, 2021
@tmat tmat deleted the WatchExternalAccess branch March 22, 2021 16:53
@333fred 333fred mentioned this pull request Mar 25, 2021
Merged
@allisonchou allisonchou modified the milestones: Next, 16.10.P2 Mar 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davidwengier davidwengier davidwengier approved these changes

+1 more reviewer

@pranavkm pranavkm pranavkm approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Area-Interactive

Projects

None yet

Milestone

16.10.P2

Development

Successfully merging this pull request may close these issues.

4 participants

@tmat @pranavkm @davidwengier @allisonchou