`AddImportsAnnotation` doesn't match existing line endings

[Youssef1313]

See failure in Youssef1313/YAnalyzers#43 (also dotnet/aspnetcore#44463)

It's passing on Windows only.

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

[adityamandaleeka]

@jasonmalinowski Just to confirm, will this fix only be available in 17.5+?

[jasonmalinowski]

@adityamandaleeka: we haven't even investigated yet. The "milestone" is just tracking us at least investigating it "soonerish" rather than "laterish".

[CyrusNajmabadi]

is there a repro, or more information on what the issue is that you would like fixed?

[adityamandaleeka]

@CyrusNajmabadi The test failures in the aspnetcore PR linked above demonstrate the issue. The PR uses the AddImportsAnnotation but the new tests fail on Unix because the added imports use the LF line terminator instead of CR/LF.

Output from one of the failing tests:

Context: Iterative code fix application
content of '/0/Test0.cs' did not match. Diff shown with expected as baseline:
using System.Collections.Generic;<CR><LF>
using Microsoft.AspNetCore.Hosting;<CR><LF>
-using Microsoft.AspNetCore.Http;<CR><LF>
+using Microsoft.AspNetCore.Http;<LF>
using Microsoft.AspNetCore.Mvc;<CR><LF>
<CR><LF>
var context = new Microsoft.AspNetCore.Http.DefaultHttpContext();<CR><LF>
context.Request.Headers.Append("Accept", "text/html");

Expected: True
Actual:   False

[CyrusNajmabadi]

Wouldn't lf be the expected line ending on unix? Does the test specify the desired editorconfig eol?

[Youssef1313]

@CyrusNajmabadi I guess tests in roslyn-analyzers repo (and possibly roslyn as well?) run both on Windows and Unix and they don't seem to specify editorconfigs, and don't fail.

Moreover, what's happening for Youssef1313/YAnalyzers#43 is the exact opposite, I get CRLF on Ubuntu 😄

[Youssef1313]

Also dotnet/format#1099 seems to discourage end_of_line usage?

[CyrusNajmabadi]

Can someone create a test in roslyn that demonstrates the issue? I'm not really liking the idea of having to go try to set everything up like in the other repos to figure out what's going on here.