[release/8.0.1xx] Handle reference to non-source symbols in UseConcreteTypeAnalyzer #6960
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Codecov Report
@@ Coverage Diff @@
## release/8.0.1xx #6960 +/- ##
===================================================
- Coverage 96.39% 96.39% -0.01%
===================================================
Files 1402 1402
Lines 332092 332095 +3
Branches 11057 11059 +2
===================================================
- Hits 320131 320120 -11
- Misses 9194 9207 +13
- Partials 2767 2768 +1 |
jeffhandley
approved these changes
Sep 21, 2023
There was a problem hiding this comment.
Looks good to me. I support this based on it being a broken scenario in a new feature in .NET 8, with the issue being reported by a partner team using the preview build. Over to @artl93.
|
@jeffhandley - is there a general pattern in this scenario here we should be considering validating more broadly? (E.g. Symbols not defined in the source). |
|
Approved by Tactics via email. Ready to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #6959 to release/8.0.1xx
Issue: IndexOutOfRangeException in UseConcreteTypeAnalyzer (CA1859)
/cc @mavasani
Customer Impact
CA1859:
Use concrete types when possible for improved performanceanalyzer throwsIndexOutOfRangeExceptionat runtime when the analyzing symbol is not defined within the source.This issue is reported by internal and external users, more users could be affected after the .NET 8 release. The analyzer newly added in .NET 8, enabled by default at Info level.
Testing
A unit test that reproes the bug added.
Risk
Very low - the fix would not introduce a new warning; the fix is straightforward and unit tested