Perform exceptions path analysis for all flow analyses #6828
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes dotnet#5199 Fixes dotnet#5160 We already had implementation and option based support to perform exception path analysis to handle all operations that can potentially throw an exception, and hence need flow analysis data at the point of operation to be merged with analysis data at start of reachable catch blocks from that operation. However, we were only performing this analysis post pass when flow analysis is looking at exceptions data. Now we do it for all analysis as this is required for more accurate input analysis data at start of catch and finally blocks. NOTE: Fixing this issue led to an assert firing in CodeAnalysis dataflow operation visitor for an existing unit test, which has also been fixed in this PR
mavasani
commented
Aug 2, 2023
Comment on lines
+118
to
+123
| // If we are executing exception paths analysis OR have at least one try/catch/finally block | ||
| // in the method, execute an exception path analysis post pass. | ||
| // This post pass will handle all possible operations within the control flow graph that can | ||
| // throw an exception and merge analysis data after all such operation analyses into the | ||
| // catch blocks reachable from those operations. | ||
| if (analysisContext.ExceptionPathsAnalysis || hasAnyTryBlock) |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #6828 +/- ##
==========================================
+ Coverage 96.36% 96.37% +0.01%
==========================================
Files 1401 1401
Lines 329956 330237 +281
Branches 10837 10841 +4
==========================================
+ Hits 317968 318272 +304
+ Misses 9256 9242 -14
+ Partials 2732 2723 -9 |
Youssef1313
reviewed
Aug 2, 2023
| @@ -286,11 +291,9 @@ protected DataFlowAnalysis(AbstractAnalysisDomain<TAnalysisData> analysisDomain, | |||
|
|
|||
| // Check if we are starting a try region which has one or more associated catch/filter regions. | |||
| // If so, we conservatively merge the input data for try region into the input data for the associated catch/filter regions. | |||
| #pragma warning disable CA1508 // Avoid dead conditional code - https://github.com/dotnet/roslyn-analyzers/issues/4408 | |||
Youssef1313
approved these changes
Aug 2, 2023
This was referenced Aug 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5199
Fixes #5160
Fixes #4984
We already had implementation and option based support to perform exception path analysis to handle all operations that can potentially throw an exception, and hence need flow analysis data at the point of operation to be merged with analysis data at start of reachable catch blocks from that operation. However, we were only performing this analysis post pass when flow analysis is looking at exceptions data. Now we do it for all analysis as this is required for more accurate input analysis data at start of catch and finally blocks.
NOTE: Fixing this issue led to an assert firing in CodeAnalysis dataflow operation visitor for an existing unit test, which has also been fixed in this PR