CA2249: Also trigger on String.IndexOf() != -1
#6774
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extends the analyer and fixer to handle not equals for String.IndexOf. Fix dotnet#6587
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #6774 +/- ##
=======================================
Coverage 96.33% 96.34%
=======================================
Files 1386 1386
Lines 325658 325667 +9
Branches 10718 10712 -6
=======================================
+ Hits 313734 313750 +16
+ Misses 9213 9205 -8
- Partials 2711 2712 +1 |
mavasani
approved these changes
Jul 17, 2023
amiru3f
pushed a commit
to amiru3f/roslyn-analyzers
that referenced
this pull request
Jul 26, 2023
CA2249: Also trigger on `String.IndexOf() != -1`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ran the new version against
dotnet/runtimeand found one new case:runtime/src/coreclr/tools/Common/Compiler/ProcessLinkerXmlBase.cs#L214
Also ran it against
dotnet/roslyn-- found multipleCA2249, but most of them were already covered before this PR:Paths
I did not manage to run it against
dotnet/roslyn-analyzers.The rule did not trigger at all, even if I added a already covered case, e.g.
var test = "str".IndexOf('a') == -1.I tried it again with
dotnet_diagnostic.CA2249.severity = warningadded to the.editorconfigwith no luck.Fixes #6587