Improve PropertiesShouldNotBeWriteOnly performance #6736
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #6736 +/- ##
=======================================
Coverage 96.33% 96.33%
=======================================
Files 1393 1393
Lines 325082 325084 +2
Branches 10711 10712 +1
=======================================
+ Hits 313160 313163 +3
+ Misses 9217 9215 -2
- Partials 2705 2706 +1 |
mavasani
approved these changes
Jul 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ends up allocating
Location[]here:roslyn-analyzers/src/Utilities/Compiler/Options/AnalyzerOptionsExtensions.cs
Line 34 in 9653f96
and
MatchesConfiguredVisibilitymight be generally slow. So we avoid calling it until we are about to issue a diagnostic.In the trace I'm looking at currently, there is not so much allocations, but still an improvement.