Disable CA1510 for shared files

[mavasani]

This broke with #6364.

See the following CI errors on all PRs with sources from main:

Build FAILED.

/mnt/vss/_work/1/s/src/Utilities/Compiler/Extensions/StringExtensions.cs(12,13): error CA1510: Use 'ArgumentNullException.ThrowIfNull' instead of explicitly throwing a new exception instance [/mnt/vss/_work/1/s/src/Test.Utilities/Test.Utilities.csproj]
/mnt/vss/_work/1/s/src/Utilities/Compiler/Extensions/StringExtensions.cs(17,13): error CA1510: Use 'ArgumentNullException.ThrowIfNull' instead of explicitly throwing a new exception instance [/mnt/vss/_work/1/s/src/Test.Utilities/Test.Utilities.csproj]
/mnt/vss/_work/1/s/src/Utilities/Compiler/Extensions/SourceTextExtensions.cs(25,13): error CA1510: Use 'ArgumentNullException.ThrowIfNull' instead of explicitly throwing a new exception instance [/mnt/vss/_work/1/s/src/Test.Utilities/Test.Utilities.csproj]
/mnt/vss/_work/1/s/src/Utilities/Compiler/Extensions/SourceTextExtensions.cs(30,13): error CA1510: Use 'ArgumentNullException.ThrowIfNull' instead of explicitly throwing a new exception instance [/mnt/vss/_work/1/s/src/Test.Utilities/Test.Utilities.csproj]
/mnt/vss/_work/1/s/src/Utilities/Compiler/Extensions/IEnumerableExtensions.cs(16,13): error CA1510: Use 'ArgumentNullException.ThrowIfNull' instead of explicitly throwing a new exception instance [/mnt/vss/_work/1/s/src/Test.Utilities/Test.Utilities.csproj]
/mnt/vss/_work/1/s/src/Utilities/Compiler/Extensions/IEnumerableExtensions.cs(36,13): error CA1510: Use 'ArgumentNullException.ThrowIfNull' instead of explicitly throwing a new exception instance [/mnt/vss/_work/1/s/src/Test.Utilities/Test.Utilities.csproj]
/mnt/vss/_work/1/s/src/Utilities/Compiler/Extensions/StringExtensions.cs(27,13): error CA1510: Use 'ArgumentNullException.ThrowIfNull' instead of explicitly throwing a new exception instance [/mnt/vss/_work/1/s/src/Test.Utilities/Test.Utilities.csproj]
/mnt/vss/_work/1/s/src/Utilities/Compiler/Extensions/StringExtensions.cs(32,13): error CA1510: Use 'ArgumentNullException.ThrowIfNull' instead of explicitly throwing a new exception instance [/mnt/vss/_work/1/s/src/Test.Utilities/Test.Utilities.csproj]
/mnt/vss/_work/1/s/src/Utilities/Compiler/Extensions/IEnumerableExtensions.cs(113,13): error CA1510: Use 'ArgumentNullException.ThrowIfNull' instead of explicitly throwing a new exception instance [/mnt/vss/_work/1/s/src/Test.Utilities/Test.Utilities.csproj]
/mnt/vss/_work/1/s/src/Utilities/Compiler/Extensions/IEnumerableExtensions.cs(187,13): error CA1510: Use 'ArgumentNullException.ThrowIfNull' instead of explicitly throwing a new exception instance [/mnt/vss/_work/1/s/src/Test.Utilities/Test.Utilities.csproj]
/mnt/vss/_work/1/s/src/Utilities/Compiler/Extensions/IEnumerableExtensions.cs(150,13): error CA1510: Use 'ArgumentNullException.ThrowIfNull' instead of explicitly throwing a new exception instance [/mnt/vss/_work/1/s/src/Test.Utilities/Test.Utilities.csproj]
/mnt/vss/_work/1/s/src/Utilities/Compiler/Extensions/IOperationExtensions.cs(248,13): error CA1510: Use 'ArgumentNullException.ThrowIfNull' instead of explicitly throwing a new exception instance [/mnt/vss/_work/1/s/src/Test.Utilities/Test.Utilities.csproj]
/mnt/vss/_work/1/s/src/Utilities/Compiler/Extensions/IOperationExtensions.cs(282,13): error CA1510: Use 'ArgumentNullException.ThrowIfNull' instead of explicitly throwing a new exception instance [/mnt/vss/_work/1/s/src/Test.Utilities/Test.Utilities.csproj]
    0 Warning(s)
    13 Error(s)

[mavasani]

@Youssef1313 @Evangelink @jmarolf Need this PR to fix the build break in the repo.

[mavasani]

@Youssef1313 @jmarolf It seems all tests are failing after migration to .net7 and no test results are also getting published to AzDo. I am going to revert #6364 for now to unblock CI on the repo.

[Youssef1313]

Curious how #6364 got green

[mavasani]

@Youssef1313 I have tried to push the .NET8 change here. Locally, the tests are still failing for me with the below error:

Message: 
    NuGet.Resolver.NuGetResolverInputException : Unable to find package 'Microsoft.CodeAnalysis'. Existing packages must be restored before performing an install or update.

  Stack Trace: 
PackageResolver.Resolve(PackageResolverContext context, CancellationToken token)
    ReferenceAssemblies.ResolveCoreAsync(String language, CancellationToken cancellationToken) line 272
    ReferenceAssemblies.ResolveAsync(String language, CancellationToken cancellationToken) line 197
    ReferenceAssemblies.ResolveAsync(String language, CancellationToken cancellationToken) line 174
    AnalyzerTest`1.CreateSolutionAsync(ProjectId projectId, EvaluatedProjectState projectState, CancellationToken cancellationToken) line 1235
    AnalyzerTest`1.CreateProjectImplAsync(EvaluatedProjectState primaryProject, ImmutableArray`1 additionalProjects, CancellationToken cancellationToken) line 1050
    AnalyzerTest`1.CreateProjectAsync(EvaluatedProjectState primaryProject, ImmutableArray`1 additionalProjects, CancellationToken cancellationToken) line 1029
    AnalyzerTest`1.GetSolutionAsync(EvaluatedProjectState primaryProject, ImmutableArray`1 additionalProjects, IVerifier verifier, CancellationToken cancellationToken) line 1007
    AnalyzerTest`1.GetSortedDiagnosticsAsync(EvaluatedProjectState primaryProject, ImmutableArray`1 additionalProjects, ImmutableArray`1 analyzers, IVerifier verifier, CancellationToken cancellationToken) line 890
    AnalyzerTest`1.VerifyDiagnosticsAsync(EvaluatedProjectState primaryProject, ImmutableArray`1 additionalProjects, DiagnosticResult[] expected, IVerifier verifier, CancellationToken cancellationToken) line 273
    CodeFixTest`1.RunImplAsync(CancellationToken cancellationToken) line 304
    AnalyzerTest`1.RunAsync(CancellationToken cancellationToken) line 181
    CSharpCodeFixVerifier`2.VerifyCodeFixAsync(String source, DiagnosticResult[] expected, String fixedSource) line 52
    CSharpCodeFixVerifier`2.VerifyCodeFixAsync(String source, String fixedSource) line 38
    FixerWithFixAllFixerTests.CSharp_NoDiagnosticAsync() line 192
    --- End of stack trace from previous location ---

[Youssef1313]

Never seen this one before. If it passed in CI, would you be able to try cleaning %TEMP% locally? The testing library downloads stuff there and there might be problems with previous downloads being cached? Not sure

[mavasani]

@Youssef1313 Seems like there are more issues here. I am going to get the revert PR #6429 in. Feel free to push more commits here if you think there is some trivial changes to bring this up.

[mavasani]

Closing this out as this seems to need more work.